Skip to content

Add integration tests for showing similar series #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
0pdd opened this issue Dec 23, 2018 · 7 comments · Fixed by #1116
Closed

Add integration tests for showing similar series #993

0pdd opened this issue Dec 23, 2018 · 7 comments · Fixed by #1116
Assignees
Milestone

Comments

@0pdd
Copy link

0pdd commented Dec 23, 2018

The puzzle 967-57830854 from #967 has to be resolved:

<!--/* @todo #967 Add integration tests for showing similar series */-->

The puzzle was created by Slava Semushin on 23-Dec-18.


  • we need to create 2 series and mark them as similar
  • as anonymous user open a page with the first of series, check that:
    • there is a block with header "Similar series"
    • this block has a link to another series
  • click on that series
  • on the page with another series, check that:
    • there is a block with header "Similar series"
    • this block has a link to the first series
@0pdd 0pdd added the techdebt label Dec 23, 2018
@php-coder php-coder changed the title Add integration tests for showing similar series */--> Add integration tests for showing similar series Dec 23, 2018
@0pdd
Copy link
Author

0pdd commented Jan 12, 2019

The puzzle 967-57830854 has disappeared from the source code, that's why I closed this issue.

@php-coder
Copy link
Owner

It's still there but it was closed (and a new one was created) because of the bug in pdd/0pdd.

@mukeshk
Copy link
Contributor

mukeshk commented Aug 31, 2019

  1. Create a new Test data script
    Create 2 new records in series and make an entry in the similar_series table
  2. Should we use the select max strategy to fetch the newly assigned primary key for the series table?
  3. Which User I should assign to the new series record?

@php-coder
Copy link
Owner

Which User I should assign to the new series record?

This is available for all users, including non-authenticated, so let's use anonymous user.

@mukeshk
Copy link
Contributor

mukeshk commented Aug 31, 2019 via email

@php-coder
Copy link
Owner

Should we use the select max strategy to fetch the newly assigned primary key for the series table?

In the commit 0131f32 I've started to use a little different approach. Every series should have a quantity that matches its id. So, in order to get id of the series we can select by its quantity (see the commits for example).

@php-coder
Copy link
Owner

Not for search function, but for the user on the series table.

User anonymous user for all these tests.

mukeshk added a commit to mukeshk/mystamps that referenced this issue Sep 1, 2019
mukeshk added a commit to mukeshk/mystamps that referenced this issue Sep 1, 2019
mukeshk added a commit to mukeshk/mystamps that referenced this issue Sep 1, 2019
mukeshk added a commit to mukeshk/mystamps that referenced this issue Sep 2, 2019
@php-coder php-coder added the estimation/30m Estimated time: 30 minutes label Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants