Skip to content

Add integration tests for showing similar series #1116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2019
Merged

Add integration tests for showing similar series #1116

merged 1 commit into from
Sep 2, 2019

Conversation

mukeshk
Copy link
Contributor

@mukeshk mukeshk commented Sep 1, 2019 •
edited by php-coder
Loading

Fix #993

@mukeshk mukeshk requested a review from php-coder as a code owner September 1, 2019 13:52
@mukeshk mukeshk force-pushed the gh993_test_showing_similar_series branch from b6768eb to d85a660 Compare September 1, 2019 13:55
@mystamps-bot
Copy link

mystamps-bot commented Sep 1, 2019 •
edited
Loading

1 Warning
⚠️ danger check: pull request description doesn’t contain a link to original issue.
Consider adding a comment in the following format: Addressed to #XXX where XXX is an issue number

Generated by 🚫 Danger

php-coder
php-coder requested changes Sep 1, 2019
View reviewed changes
Copy link
Owner

@php-coder php-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! See my comments.

@mukeshk mukeshk force-pushed the gh993_test_showing_similar_series branch from d85a660 to 3bfca38 Compare September 1, 2019 17:43
@php-coder
Copy link
Owner

Don't forget to remove an original comment with TODO item.

php-coder
php-coder reviewed Sep 1, 2019
View reviewed changes
php-coder
php-coder reviewed Sep 1, 2019
View reviewed changes
php-coder
php-coder reviewed Sep 1, 2019
View reviewed changes
php-coder
php-coder requested changes Sep 1, 2019
View reviewed changes
Copy link
Owner

@php-coder php-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's close to a state when it can be merged :-)

@mukeshk mukeshk force-pushed the gh993_test_showing_similar_series branch from 3bfca38 to 68efabf Compare September 2, 2019 04:15
php-coder
php-coder approved these changes Sep 2, 2019
View reviewed changes
Copy link
Owner

@php-coder php-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@php-coder php-coder merged commit 1331005 into php-coder:master Sep 2, 2019
@php-coder
Copy link
Owner

Super! Thank you, @mukeshk ! :shipit:

@php-coder
Copy link
Owner

Ah, I overlooked that a commit message contains outdated path to the file:

test(/series/search/logic-anonymous.robot): add tests for showing similar series

Next time, I hope I'll noticed it.

@mukeshk
Copy link
Contributor Author

mukeshk commented Sep 2, 2019 via email •
edited by php-coder
Loading

@mukeshk mukeshk deleted the gh993_test_showing_similar_series branch September 3, 2019 09:21
@mukeshk
Copy link
Contributor Author

mukeshk commented Sep 7, 2019

image

@mukeshk
Copy link
Contributor Author

mukeshk commented Sep 7, 2019

I am sending empty data. Getting a bad request.
What should be request body ?

@php-coder
Copy link
Owner

php-coder commented Sep 8, 2019 •
edited
Loading

I am sending empty data. Getting a bad request. What should be request body ?

I've answered to that in your pull request.

(Note also that you've commented on an already closed PR :) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@php-coder php-coder php-coder approved these changes

Assignees
No one assigned
Labels
resolution/merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add integration tests for showing similar series
3 participants
@mukeshk @mystamps-bot @php-coder