-
Notifications
You must be signed in to change notification settings - Fork 34
Add integration tests for showing similar series #1116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration tests for showing similar series #1116
Conversation
b6768eb
to
d85a660
Compare
Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! See my comments.
src/main/resources/liquibase/version/0.4.1/2019-08-31--test_showing_similar_series.xml
Outdated
Show resolved
Hide resolved
src/main/resources/liquibase/version/0.4.1/2019-08-31--test_showing_similar_series.xml
Outdated
Show resolved
Hide resolved
src/main/resources/liquibase/version/0.4.1/2019-08-31--test_showing_similar_series.xml
Outdated
Show resolved
Hide resolved
d85a660
to
3bfca38
Compare
Don't forget to remove an original comment with TODO item. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's close to a state when it can be merged :-)
3bfca38
to
68efabf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Super! Thank you, @mukeshk ! |
Ah, I overlooked that a commit message contains outdated path to the file:
Next time, I hope I'll noticed it. |
Even I didn't realize it
|
I am sending empty data. Getting a bad request. |
I've answered to that in your pull request. (Note also that you've commented on an already closed PR :) ) |
Fix #993