Skip to content

refactor: Removed hard-coding of h2 console path and used H2ConsoleProperties i… #1305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

refactor: Removed hard-coding of h2 console path and used H2ConsoleProperties i… #1305

wants to merge 2 commits into from

Conversation

mscibilia
Copy link
Contributor

…nstead.

Change for #1269

@mscibilia mscibilia requested a review from php-coder as a code owner March 28, 2020 02:45
@mscibilia mscibilia changed the title Removed hard-coding of h2 console path and used H2ConsoleProperties i… refactor: Removed hard-coding of h2 console path and used H2ConsoleProperties i… Mar 28, 2020
@mystamps-bot
Copy link

mystamps-bot commented Mar 28, 2020 •
edited
Loading

3 Errors
🚫 maven-checkstyle-plugin error in src/test/java/ru/mystamps/web/support/spring/security/ContentSecurityPolicyHeaderWriterTest.java#L94:
Line is longer than 100 characters (found 108)
🚫 maven-checkstyle-plugin error in src/test/java/ru/mystamps/web/support/spring/security/ContentSecurityPolicyHeaderWriterTest.java#L113:
Line has trailing spaces
🚫 maven-checkstyle-plugin error in src/test/java/ru/mystamps/web/support/spring/security/ContentSecurityPolicyHeaderWriterTest.java#L356:
Line is longer than 100 characters (found 107)
3 Warnings
⚠️ danger check: pull request description doesn’t contain a link to original issue.
Consider adding a comment in the following format: Addressed to #XXX where XXX is an issue number
⚠️ danger check: pull request contains 2 commits while most of the cases it should have only one. If it’s not a special case you should squash the commits into single one.
But be careful because it can destroy all your changes!
⚠️ danger check: branch issue-1269-Reduce-h2-console-path-hard-coding does not comply with our best practices. Branch name should use the following scheme: ghXXX_meaningful-name where XXX is an issue number. Next time, please, use this scheme :)
1 Message
📖 maven-checkstyle-plugin reported about 3 errors. Please, fix them. See also: https://github.com/php-coder/mystamps/wiki/checkstyle

Generated by 🚫 Danger

@mscibilia
Refactored name of constant to conform with best practice naming conv…
54f97d1 
…ention and reduced line lengths to be under 100.
@mscibilia mscibilia closed this Mar 28, 2020
@mscibilia mscibilia deleted the issue-1269-Reduce-h2-console-path-hard-coding branch March 28, 2020 08:35
@mscibilia
Copy link
Contributor Author

Closed to be re-open with proper conventions for repo

@php-coder
Copy link
Owner

Closed to be re-open with proper conventions for repo

It wasn't required by the way as this was a warning.

@php-coder
Copy link
Owner

Duplicate of #1306

@php-coder php-coder marked this as a duplicate of #1306 Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@php-coder php-coder Awaiting requested review from php-coder php-coder is a code owner

Assignees
No one assigned
Labels
resolution/duplicate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mscibilia @mystamps-bot @php-coder