Skip to content

refactor: Refactored to remove hasH2Console boolean flag and replace … #1308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mscibilia
Copy link
Contributor

…it with a check on the H2 console properties/path.

Fix #1307

@mscibilia mscibilia requested a review from php-coder as a code owner March 31, 2020 16:29
@mscibilia mscibilia self-assigned this Mar 31, 2020
@mystamps-bot
Copy link

mystamps-bot commented Mar 31, 2020

1 Warning
⚠️ danger check: pull request description doesn’t contain a link to original issue.
Consider adding a comment in the following format: Addressed to #XXX where XXX is an issue number

Generated by 🚫 Danger

@php-coder
Copy link
Owner

@mscibilia Don't forget to update unit tests ;)

…it with a check on the H2 console properties/path.

Fix #1307
@mscibilia mscibilia force-pushed the gh1307_Remove-boolean-flag-hasH2Console branch from ecd2fdd to 86b25fc Compare April 1, 2020 00:20
@mscibilia
Copy link
Contributor Author

accidentally pushed this branch to upstream instead of origin, will re-create it properly.

@mscibilia mscibilia closed this Apr 1, 2020
@mscibilia mscibilia deleted the gh1307_Remove-boolean-flag-hasH2Console branch April 1, 2020 00:26
@php-coder
Copy link
Owner

Duplicate of #1309

@php-coder php-coder marked this as a duplicate of #1309 Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove or replace usage of hasH2Console variable
3 participants