Skip to content

Remove or replace usage of hasH2Console variable #1307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
php-coder opened this issue Mar 31, 2020 · 0 comments · Fixed by #1309
Closed

Remove or replace usage of hasH2Console variable #1307

php-coder opened this issue Mar 31, 2020 · 0 comments · Fixed by #1309
Assignees
@mscibilia
Labels
refactoring techdebt trivial
Milestone
0.4.4

Comments

@php-coder
Copy link
Owner

ContentSecurityPolicyHeaderWriter and SecurityConfig use hasH2Console variable (or constructor argument) while the is a variable with a path to H2 console. We don't need 2 variables as we have H2 console when its path isn't null. I suggest to remove hasH2Console flag from constructors at least.

Tech debt for: 13657e0 (#1269, #1306)
@php-coder php-coder mentioned this issue Mar 31, 2020
Merged
mscibilia added a commit that referenced this issue Mar 31, 2020
@mscibilia
refactor: Refactored to remove hasH2Console boolean flag and replace …
ecd2fdd 
…it with a check on the H2 console properties/path.

Fix #1307
@mscibilia mscibilia mentioned this issue Mar 31, 2020
Closed
mscibilia added a commit to mscibilia/mystamps that referenced this issue Apr 1, 2020
@mscibilia
refactor: Refactored to remove hasH2Console boolean flag and replace …
86b25fc 
…it with a check on the H2 console properties/path.

Fix php-coder#1307
@mscibilia mscibilia mentioned this issue Apr 1, 2020
Merged
@mscibilia mscibilia linked a pull request Apr 1, 2020 that will close this issue
refactor: Refactored to remove hasH2Console boolean flag and replace … #1309
Merged
mscibilia added a commit to mscibilia/mystamps that referenced this issue Apr 1, 2020
@mscibilia
refactor: Refactored to remove hasH2Console boolean flag and replace …
f7f8b1d 
…it with a check on the H2 console properties/path.

Fix php-coder#1307
@php-coder php-coder added this to the 0.4.4 milestone Apr 1, 2020
mscibilia added a commit to mscibilia/mystamps that referenced this issue Apr 2, 2020
@mscibilia
refactor: Refactored to remove hasH2Console boolean flag and replace …
6af47d6 
…it with a check on the H2 console properties/path.

Fix php-coder#1307
php-coder pushed a commit that referenced this issue Apr 2, 2020
@mscibilia @php-coder
refactor: Refactored to remove hasH2Console boolean flag and replace …
c4d9e27 
…it with a check on the H2 console properties/path.

Fix #1307
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mscibilia mscibilia

Labels
refactoring techdebt trivial
Projects
None yet
Milestone
0.4.4
2 participants
@php-coder @mscibilia