Skip to content

Make benchmark comparison search for last benchmarked commit #18094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
iluuu1994 opened this issue Mar 16, 2025 · 0 comments
Closed

Make benchmark comparison search for last benchmarked commit #18094

iluuu1994 opened this issue Mar 16, 2025 · 0 comments
Assignees
@iluuu1994
Labels
Category: CI Feature Status: Verified

Comments

@iluuu1994
Copy link
Member

Description

Can we please amend the benchmark CI job so that it picks the last commit that has a benchmark run?
The number of times I've seen Base commit 'xyz' not found due to xyz still being benched is really high
@iluuu1994 iluuu1994 self-assigned this Mar 16, 2025
iluuu1994 added a commit to iluuu1994/php-src that referenced this issue Mar 26, 2025
@iluuu1994
Implement benchmark diff commit fallback
09aa386 
When the base commit is not benchmarked (yet), iterate first parents of
the commit until we find one.

Fixes phpGH-18094
@iluuu1994 iluuu1994 mentioned this issue Mar 26, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iluuu1994 iluuu1994

Labels
Category: CI Feature Status: Verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement benchmark diff commit fallback iluuu1994/php-src
1 participant
@iluuu1994