Implement benchmark diff commit fallback #18152
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the base commit is not benchmarked (yet), iterate first parents of the commit until we find one. Fixes phpGH-18094
mvorisek
reviewed
Mar 26, 2025
nielsdos
approved these changes
Mar 26, 2025
mvorisek
reviewed
Mar 29, 2025
| if (file_exists($summaryFile)) { | ||
| break; | ||
| } | ||
| $commitHash = trim(runCommand(['git', 'rev-parse', $commitHash . '^'], dirname(__DIR__))->stdout); |
There was a problem hiding this comment.
This must not print anything to the console - https://github.com/php/php-src/actions/runs/14118010354
There was a problem hiding this comment.
Good catch! I'll fix this later tonight.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the base commit is not benchmarked (yet), iterate first parents of the commit until we find one that is.
Fixes GH-18094