Skip to content

statements: add privilege details #21815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 30, 2025
Merged

statements: add privilege details #21815

merged 7 commits into from
Sep 30, 2025
+13 −1

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Sep 19, 2025

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 19, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 19, 2025
@dveeden dveeden requested a review from qiancai September 19, 2025 09:39
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 19, 2025
@dveeden
Copy link
Contributor Author

dveeden commented Sep 19, 2025

cc @kissmydb @mjonss

mjonss
mjonss approved these changes Sep 21, 2025
View reviewed changes
Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 21, 2025

@mjonss: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dveeden dveeden marked this pull request as ready for review September 22, 2025 06:46
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 22, 2025
@qiancai qiancai self-assigned this Sep 22, 2025
@qiancai qiancai added needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Sep 22, 2025
qiancai
qiancai approved these changes Sep 22, 2025
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

qiancai
qiancai approved these changes Sep 22, 2025
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@qiancai qiancai added translation/doing This PR's assignee is translating this PR. type/enhancement The issue or PR belongs to an enhancement. and removed missing-translation-status This PR does not have translation status info. labels Sep 22, 2025
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 22, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 22, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-09-22 08:44:35.067720016 +0000 UTC m=+259885.138213717: ☑️ agreed by qiancai.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 22, 2025

@qiancai: Your lgtm message is repeated, so it is ignored.

In response to this:

Rest LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

qiancai added a commit to qiancai/docs-cn that referenced this pull request Sep 30, 2025
@qiancai
translate pingcap/docs#21815
196186b
@qiancai qiancai mentioned this pull request Sep 30, 2025
Merged
14 tasks
@qiancai qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Sep 30, 2025
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 30, 2025
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 30, 2025
qiancai
qiancai reviewed Sep 30, 2025
View reviewed changes
sql-statements/sql-statement-create-binding.md Outdated
## SQL statement truncation

When you use `CREATE BINDING ... FROM HISTORY USING PLAN DIGEST`, the binding can fail if the SQL statement stored in [statement summary tables](/statement-summary-tables.md) for that digest is truncated because it is longer than [`tidb_stmt_summary_max_sql_length`](/system-variables.md#tidb_stmt_summary_max_sql_length-new-in-v40). In this case, you need to increase `tidb_stmt_summary_max_sql_length`.
=======
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
=======

@qiancai
Copy link
Collaborator

qiancai commented Sep 30, 2025

/approve

@qiancai qiancai added the lgtm label Sep 30, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 30, 2025
@ti-chi-bot ti-chi-bot bot merged commit ba15c6e into pingcap:master Sep 30, 2025
9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #21860.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 30, 2025
Open
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #21861.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 30, 2025
Open
14 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Sep 30, 2025
@qiancai @ti-chi-bot
translate pingcap/docs#21815
4bc3fe7
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 30, 2025
Open
14 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Sep 30, 2025
@qiancai @ti-chi-bot
translate pingcap/docs#21815
c56d848
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 30, 2025
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai approved these changes

@mjonss mjonss mjonss approved these changes

Assignees

@qiancai qiancai

Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dveeden @qiancai @ti-chi-bot @mjonss