statements: add privilege details (#21815) #21861
Conversation
Co-authored-by: Grace Cai <[email protected]>
Co-authored-by: Grace Cai <[email protected]>
Co-authored-by: Grace Cai <[email protected]>
Co-authored-by: Grace Cai <[email protected]>
ti-chi-bot
added
lgtm
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary of ChangesHello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the clarity and completeness of the TiDB documentation by adding explicit privilege requirements for several SQL statements and information schema views. These updates ensure users have a clear understanding of the necessary permissions to execute Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds important privilege information to the documentation for PROCESSLIST, CREATE BINDING, and SHOW PROCESSLIST. My review provides minor suggestions to improve the phrasing for better clarity and to align with the style guide's preference for using the second person.
|
|
||
| ## Permissions | ||
|
|
||
| If the current user does not have the `PROCESS` privilege, `PROCESSLIST` only shows the requests from the user’s own sessions. |
There was a problem hiding this comment.
For better readability and to adhere to the style guide's preference for the second person 1, I suggest rephrasing this sentence. This change also clarifies that PROCESSLIST refers to the table being queried.
| If the current user does not have the `PROCESS` privilege, `PROCESSLIST` only shows the requests from the user’s own sessions. | |
| If you do not have the `PROCESS` privilege, querying the `PROCESSLIST` table only shows the requests from your own sessions. |
Style Guide References
Footnotes
-
The style guide recommends writing in the second person ('you') when addressing users to make the documentation more direct and easier to understand. ↩
|
|
||
| ## Permissions | ||
|
|
||
| The `CREATE BINDING` statement requires the `SUPER` privilege. |
There was a problem hiding this comment.
To align with the style guide's recommendation of using the second person ('you') when addressing users 1, I suggest rephrasing this sentence to be more direct.
| The `CREATE BINDING` statement requires the `SUPER` privilege. | |
| To use the `CREATE BINDING` statement, you need the `SUPER` privilege. |
Style Guide References
Footnotes
-
The style guide recommends writing in the second person ('you') when addressing users. ↩
|
|
||
| ## Permissions | ||
|
|
||
| If the current user does not have the `PROCESS` privilege, `SHOW PROCESSLIST` only shows the requests from the user’s own sessions. |
There was a problem hiding this comment.
To follow the style guide's preference for using the second person ('you') 1, I recommend rephrasing this sentence for better clarity and consistency.
| If the current user does not have the `PROCESS` privilege, `SHOW PROCESSLIST` only shows the requests from the user’s own sessions. | |
| If you do not have the `PROCESS` privilege, `SHOW PROCESSLIST` only shows the requests from your own sessions. |
Style Guide References
Footnotes
-
The style guide recommends writing in the second person ('you') when addressing users. ↩
This is an automated cherry-pick of #21815
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?