fix(shared): resolve circular dependencies #1150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you have a git repo that reproduces the error in #1078, so I can clone it and test this fix? |
|
Hey @aleclarson 👋 Prepared a demo ;-) https://github.com/khmm12/react-spring-circular-dependencies-issue Reproducible on production bundle. |
khmm12
force-pushed
the
fix/shared-circular-dependencies
branch
from
6e11e33 to
d35fb1c
Compare
|
Did rebase the branch |
TheSisb
approved these changes
Oct 5, 2020
louisgv
approved these changes
Oct 13, 2020
There was a problem hiding this comment.
LGTM 👍 @khmm12 Can we get another quick rebase for this PR for @aleclarson to merge it?
`shared/helpers` wants entire `shared/globals` inside `isAnimatedString`, `shared/globals` wants `noop` from `shared/helper` to assign exported variable `willAdvance`. If `shared/helpers` is executed before `shared/globals`, `willAdvance` is initialized by given value. Otherwise `willAdvance` is initialized after `noop` inside `shared/helpers` and has no defined value. The safest way is keep `shared/helpers` pure and move `isAnimatedString` to own module.
khmm12
force-pushed
the
fix/shared-circular-dependencies
branch
from
d35fb1c to
bcf5e2f
Compare
|
@louisgv Ready ;-) |
Closed
hakanozkaptan
approved these changes
Nov 11, 2020
Closed
This comment has been minimized.
This comment has been minimized.
joshuaellis
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shared/helperswants entireshared/globalsinsideisAnimatedString,shared/globalswantsnoopfromshared/helperto assign exported variablewillAdvance.If
shared/helpersis executed beforeshared/globals,willAdvanceis initialized by given value. OtherwisewillAdvanceis initialized afternoopinsideshared/helpersand has no defined value.The safest way is keep
shared/helperspure and moveisAnimatedStringto own module.It fixes #1078