Hotfix for v9.0.0-rc.3 #1229
Closed
Hotfix for v9.0.0-rc.3 #1229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`shared/helpers` wants entire `shared/globals` inside `isAnimatedString`, `shared/globals` wants `noop` from `shared/helper` to assign exported variable `willAdvance`. If `shared/helpers` is executed before `shared/globals`, `willAdvance` is initialized by given value. Otherwise `willAdvance` is initialized after `noop` inside `shared/helpers` and has no defined value. The safest way is keep `shared/helpers` pure and move `isAnimatedString` to own module.
|
Hey @heyimalex, why should this be merged over #1150? It looks to do the same? or have I missed something? |
|
I think it's exactly the same, maybe avoids some merge conflicts. The goal was just to make it easy to release an rc4 based on the rc3 branch that prevents the linked issue, since it seemed like work has stalled a bit on v9 in general and cutting a new release off main wouldn't happen for a while. |
|
closing in favour of #1150 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the discussion in #1078, this takes the v9.0.0-rc.3 tagged commit and applies the fix from #1150
To demonstrate the fix works, you can check out this branch which has instructions included in the readme. Repro is as bare minimum as I could get.