Skip to content

Add test cases for concurrent reduction #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Add test cases for concurrent reduction #143

wants to merge 5 commits into from

Conversation

yiming-tang-cs
Copy link
Contributor

khatchad
khatchad requested changes Jan 3, 2018
View reviewed changes
Copy link
Member

@khatchad khatchad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests must fail since we have not implemented the code for this yet. Please review test driven development https://technologyconversations.com/2013/12/20/test-driven-development-tdd-example-walkthrough/.

@khatchad
Copy link
Member

khatchad commented Jan 3, 2018

Also, just adding test cases never entails changing the functional code.

@khatchad
Copy link
Member

khatchad commented Jan 3, 2018

Also, I am a bit confused about the tests themselves. Do they correspond to the table in the draft? Are we testing the state of the collectors?

@khatchad
Copy link
Member

khatchad commented Jan 3, 2018

BTW, this will not be pulled into master but rather another branch. That way, we can keep master passing.

@khatchad khatchad added this to the Complex mutable reductions milestone Jan 3, 2018
@yiming-tang-cs
Copy link
Contributor Author

The tests must fail since we have not implemented the code for this yet. Please review test driven development https://technologyconversations.com/2013/12/20/test-driven-development-tdd-example-walkthrough/.

Thank you for your explanation and links. The way to process exceptions in the link needs org.junit.Test which conflicts with junit.framework.Test which is imported by you. Hence, I did not choose it.

@yiming-tang-cs yiming-tang-cs mentioned this pull request Jan 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khatchad khatchad khatchad requested changes

Assignees

@yiming-tang-cs yiming-tang-cs

Labels
infrastructure
Projects
None yet
Milestone
Complex mutable reductions
Development

Successfully merging this pull request may close these issues.
2 participants
@yiming-tang-cs @khatchad