Add test cases for concurrent reductions #150

yiming-tang-cs · 2018-01-04T17:31:42Z

The old pull request: #143

This reverts commit 034b677.

khatchad

You are missing the column we discussed from Table 3.

khatchad · 2018-01-04T23:58:22Z

...factoring.core/src/edu/cuny/hunter/streamrefactoring/core/analysis/TransformationAction.java

-	CONVERT_TO_SEQUENTIAL
-
+	CONVERT_TO_SEQUENTIAL,
+	CONVERT_TO_CONCURRENT,


Can we be more specific here? Concurrent what? Likewise for non-concurrent.

Do I make more specific for CONVERT_TO_SEQUENTIAL? I thought CONVERT_TO_SEQUENTIAL and CONVERT_TO_CONCURRENT have the same format.

No, you can leave those. Let's make the new code specific.

CONVERT_COLLECTOR_TO_CONCURRENT? Is that what you mean?

Please go with that

khatchad · 2018-01-04T23:59:49Z

...cases/edu/cuny/hunter/streamrefactoring/ui/tests/ConvertStreamToParallelRefactoringTest.java

+	 */
+	public void testConcurrentReduction() throws Exception {
+		helper(new StreamAnalysisExpectedResult("orderedWidgets.stream()",
+				Collections.singleton(ExecutionMode.SEQUENTIAL), Collections.singleton(Ordering.ORDERED), false, false,


Please use EnumSet.of(). It should be more efficient.

Other test cases also accept Collections.singleton for execution mode and ordering. Should I change them all?

No. Please focus on the new code.

yiming-tang-cs · 2018-01-05T01:41:58Z

You are missing the column we discussed from Table 3.

Also test collector kind in helper method?

khatchad · 2018-01-05T02:16:02Z

...factoring.core/src/edu/cuny/hunter/streamrefactoring/core/analysis/TransformationAction.java

-	CONVERT_TO_SEQUENTIAL
-
+	CONVERT_TO_SEQUENTIAL,
+	CONVERT_TO_CONCURRENT,


CONVERT_COLLECTOR_TO_CONCURRENT? Is that what you mean?

yiming-tang-cs · 2018-01-05T02:18:02Z

CONVERT_COLLECTOR_TO_CONCURRENT? Is that what you mean?

Yes.

…am-Refactoring into issue_138

khatchad · 2018-01-05T02:22:46Z

Please go with that. On Fri, 2018-01-05 at 02:18 +0000, Grace Tang wrote: CONVERT_COLLECTOR_TO_CONCURRENT? Is that what you mean? Yes. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub<#150 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AB9DPz4XO1XIxEDxbgy3A9Jf3F6zun4sks5tHYZbgaJpZM4RTUzA>.

yiming-tang-cs · 2018-01-05T02:26:31Z

You are missing the column we discussed from Table 3?

I think the only column I am missing is collector kind. You want test it in helper method?

khatchad

This is poor work overall. You must learn how to reuse existing code.

khatchad · 2018-01-05T17:06:11Z

...unter.streamrefactoring.core/src/edu/cuny/hunter/streamrefactoring/core/analysis/Stream.java

@@ -634,6 +636,10 @@ public PreconditionSuccess getPassingPrecondition() {
 		return possibleOrderings.stream().map(e -> e == null ? initialOrdering : e).collect(Collectors.toSet());
 	}

+	public CollectorKind getCollectorKind() {
+		return null;


No. There should be a field returned here.

khatchad · 2018-01-05T17:07:21Z

...st cases/edu/cuny/hunter/streamrefactoring/ui/tests/ComplexStreamAnalysisExpectedResult.java

+import edu.cuny.hunter.streamrefactoring.core.analysis.Refactoring;
+import edu.cuny.hunter.streamrefactoring.core.analysis.TransformationAction;
+
+public class ComplexStreamAnalysisExpectedResult {


No way. Way too much duplication. Please explain the reason you need an entire separate class for this.

khatchad · 2018-01-05T17:08:34Z

...cases/edu/cuny/hunter/streamrefactoring/ui/tests/ConvertStreamToParallelRefactoringTest.java

+	 * Runs a single analysis test.
+	 * Test for #138. Test complex mutable reduction. 
+	 */
+	private void helper(ComplexStreamAnalysisExpectedResult... expectedResults) throws Exception {


Absolutely not. No copy and pasting.

khatchad · 2018-01-05T20:57:11Z

Actually you do not need to overload since we are passing a single object. You can just add a field to the expected result class.

khatchad

Better but there's still to much duplication.

khatchad · 2018-01-05T22:48:10Z

...unter.streamrefactoring.core/src/edu/cuny/hunter/streamrefactoring/core/analysis/Stream.java

@@ -167,6 +167,8 @@ private static String getMethodIdentifier(IMethodBinding methodBinding) {
 	private final MethodDeclaration enclosingMethodDeclaration;

 	private final TypeDeclaration enclosingTypeDeclaration;
+
+	private CollectorKind collectorKind = null;


Remove the null. It's null be default.

khatchad · 2018-01-05T22:51:37Z

...ests/test cases/edu/cuny/hunter/streamrefactoring/ui/tests/StreamAnalysisExpectedResult.java

+	/**
+	 * Overloading constructor to test complex mutable reduction
+	 */
+	public StreamAnalysisExpectedResult(String expectedCreation, Set<ExecutionMode> expectedExecutionModes,


Still too much duplication here.

I've changed constructor.

khatchad

Thank you.

yiming-tang-cs · 2018-01-05T23:36:04Z

Thank you!

* add test cases and fail the stream * calculate LOC * Revert "calculate LOC" This reverts commit 034b677. * revert changing functional code * change test cases * change test * change test cases * change refactoring * delete useless importation * Remove extra space. * change name and collections * Add collector kind * remove duplication * improve format * remove overloading helper * format * remove duplication * Remove whitespace addition.

yiming-tang-cs added 9 commits January 2, 2018 14:36

add test cases and fail the stream

dd36f41

calculate LOC

034b677

Revert "calculate LOC"

88964b6

This reverts commit 034b677.

revert changing functional code

dbace41

change test cases

50adba1

change test

fabcd68

change test cases

2c82b8a

change refactoring

400029d

delete useless importation

a5f4ad9

yiming-tang-cs requested a review from khatchad as a code owner January 4, 2018 17:31

khatchad added this to the Complex mutable reductions milestone Jan 4, 2018

Remove extra space.

a5fe445

khatchad requested changes Jan 5, 2018

View reviewed changes

yiming-tang-cs added 2 commits January 4, 2018 21:22

change name and collections

29c77a4

Merge branch 'issue_138' of https://github.com/saledouble/Java-8-Stre…

c33b8dd

…am-Refactoring into issue_138

Add collector kind

8156f1d

khatchad requested changes Jan 5, 2018

View reviewed changes

yiming-tang-cs added 2 commits January 5, 2018 13:10

remove duplication

3ddd2b1

improve format

ced2650

yiming-tang-cs added 2 commits January 5, 2018 16:18

remove overloading helper

99c2703

format

125472b

khatchad requested changes Jan 5, 2018

View reviewed changes

yiming-tang-cs and others added 2 commits January 5, 2018 18:13

remove duplication

6f7702a

Remove whitespace addition.

4845317

khatchad approved these changes Jan 5, 2018

View reviewed changes

khatchad merged commit 2c307de into ponder-lab:issue_138 Jan 5, 2018

khatchad deleted the issue_138 branch January 5, 2018 23:35

Add test cases for concurrent reductions #150

Add test cases for concurrent reductions #150

Uh oh!

Conversation

yiming-tang-cs commented Jan 4, 2018 • edited by khatchad Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

khatchad left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yiming-tang-cs commented Jan 5, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yiming-tang-cs commented Jan 5, 2018

Uh oh!

khatchad commented Jan 5, 2018 via email

Uh oh!

yiming-tang-cs commented Jan 5, 2018

Uh oh!

khatchad left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

khatchad commented Jan 5, 2018 via email • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

khatchad left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

khatchad left a comment

Choose a reason for hiding this comment

Uh oh!

yiming-tang-cs commented Jan 5, 2018

Uh oh!

Uh oh!

yiming-tang-cs commented Jan 4, 2018 •

edited by khatchad

Loading

khatchad commented Jan 5, 2018 via email •

edited

Loading