-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Fix accuracy of the non-dimensional property regex #2608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@kripod you mentioned you had a testbed for this regex - are you able to link it? I want to know which properties this is correcting for. |
Sure, the tests can be run with Please be aware that I’ve modified otion’s RegExp to accommodate for the non-hyphenated syntax, and then ran the tests by transforming CSS properties from MDN data using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you so much for the PR 🙌 We've merged it into the v11 release line and it will be included with Preact 11 🎉
Wonderful, thank you! 😊 |
Copy of #2608 Co-authored-by: Kristóf Poduszló <[email protected]>
Copy of #2608 Co-authored-by: Kristóf Poduszló <[email protected]>
Copy of #2608 Co-authored-by: Kristóf Poduszló <[email protected]>
Copy of #2608 Co-authored-by: Kristóf Poduszló <[email protected]>
Resolves #2607