Skip to content

Conversation

kripod
Copy link
Contributor

@kripod kripod commented Jul 8, 2020

Resolves #2607

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.798% when pulling c1ad272 on kripod:patch-1 into ff0bf29 on preactjs:master.

@developit
Copy link
Member

@kripod you mentioned you had a testbed for this regex - are you able to link it? I want to know which properties this is correcting for.

@kripod
Copy link
Contributor Author

kripod commented Jul 8, 2020

Sure, the tests can be run with yarn && yarn build && yarn test from the root of the otion repository. The testing code can be found here: https://github.com/kripod/otion/blob/365743c6f7374355bc8b0032b7b220a24fb3a009/packages/otion/src/propertyMatchers.test.ts

Please be aware that I’ve modified otion’s RegExp to accommodate for the non-hyphenated syntax, and then ran the tests by transforming CSS properties from MDN data using property.replace(/-[a-z]/g, (match) => match[1].toUpperCase()).

@marvinhagemeister marvinhagemeister changed the base branch from master to v11 July 16, 2020 07:34
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you so much for the PR 🙌 We've merged it into the v11 release line and it will be included with Preact 11 🎉

@marvinhagemeister marvinhagemeister merged commit a573d41 into preactjs:v11 Jul 16, 2020
@kripod
Copy link
Contributor Author

kripod commented Jul 16, 2020

Wonderful, thank you! 😊

@kripod kripod deleted the patch-1 branch July 16, 2020 08:04
rschristian added a commit that referenced this pull request May 27, 2025
rschristian added a commit that referenced this pull request May 31, 2025
rschristian added a commit that referenced this pull request May 31, 2025
JoviDeCroock pushed a commit that referenced this pull request Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IS_NON_DIMENSIONAL has false positives and false negatives
4 participants