refactor (v11): Improve accuracy of non-dimensional regex #4772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy of #2608 Co-authored-by: Kristóf Poduszló <[email protected]>
📊 Tachometer Benchmark ResultsSummaryduration
usedJSHeapSize
Resultscreate10kduration
usedJSHeapSize
filter-listduration
usedJSHeapSize
hydrate1kduration
usedJSHeapSize
many-updatesduration
usedJSHeapSize
replace1kduration
usedJSHeapSize
run-warmup-0
run-warmup-1
run-warmup-2
run-warmup-3
run-warmup-4
run-final
text-updateduration
usedJSHeapSize
tododuration
usedJSHeapSize
update10th1kduration
usedJSHeapSize
|
|
Size Change: +138 B (+0.3%) Total Size: 46.6 kB
ℹ️ View Unchanged
|
rschristian
changed the title
| @@ -13,4 +13,4 @@ export function shallowDiffers(a, b) { | |||
| } | |||
|
|
|||
| export const IS_NON_DIMENSIONAL = | |||
| /acit|ex(?:s|g|n|p|$)|rph|grid|ows|mnc|ntw|ine[ch]|zoo|^ord|itera/i; | |||
| /^(-|f[lo].*[^se]$|g.{5,}[^ps]$|z|o[pr]|(W.{5})?[lL]i.*(t|mp)$|an|(bo|s).{4}Im|sca|m.{6}[ds]|ta|c.*[st]$|wido|ini)/; | |||
There was a problem hiding this comment.
My main concern here is that this is a significant byte size increase for something that I'm not sure is worth it because style doesn't feel that widely used
There was a problem hiding this comment.
While I don't love it, I figure if we are going to offer this (which we're probably stuck with), it should be correct. Intentionally not supporting ~1/4 of the properties we should feels a bit bad for 47b in compat.
I don't have strong opinions either way though, can't say I even recall using style recently myself.
rschristian
force-pushed
the
chore/port-non-dimensional-regex-fix
branch
from
121b0a8 to
a02a441
Compare
JoviDeCroock
pushed a commit
that referenced
this pull request
Jun 6, 2025
Copy of #2608 Co-authored-by: Kristóf Poduszló <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy of #2608
Uncommented the failing cases and added a few extra that were listed in #2607 but didn't make it into our test files. It's certainly a bit bigger and likely a bit slower but thought I'd at least put this up as a suggestion as I happened to remember it.