Skip to content

chore(TreeView): Remove the CSS modules feature flag from the TreeView component #5934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 25, 2025
Merged

chore(TreeView): Remove the CSS modules feature flag from the TreeView component #5934

merged 4 commits into from
Apr 25, 2025

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Apr 16, 2025 •
edited
Loading

Closes https://github.com/github/primer/issues/4407

Changelog

New

Changed

Removed

Remove the CSS modules feature flag from the TreeView component

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 16, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 9cf417c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Apr 16, 2025
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Apr 16, 2025
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 16, 2025 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 101.68 KB (-0.99% 🔽)
packages/react/dist/browser.umd.js 101.99 KB (-0.8% 🔽)

@github-actions github-actions bot requested a deployment to storybook-preview-5934 April 16, 2025 21:09 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-5934 April 16, 2025 21:25 Inactive
@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Apr 16, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-5934 April 22, 2025 18:48 Inactive
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/374789

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@jonrohan jonrohan marked this pull request as ready for review April 24, 2025 20:46
@Copilot Copilot AI review requested due to automatic review settings April 24, 2025 20:46
@jonrohan jonrohan requested a review from a team as a code owner April 24, 2025 20:46
@jonrohan jonrohan requested a review from hectahertz April 24, 2025 20:46
@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Apr 24, 2025
Copilot
Copilot AI reviewed Apr 24, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the CSS modules feature flag from the TreeView component, simplifying the class name logic by always applying the CSS modules styling.

  • Removed the conditional CSS modules logic and toggleStyledComponent wrappers in the TreeView component.
  • Updated tests to stop wrapping components in the FeatureFlags provider.
  • Updated the changeset to document the removal of the CSS modules feature flag.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
packages/react/src/TreeView/TreeView.tsx Removed all conditional usage and dynamic flag checks for CSS modules.
packages/react/src/TreeView/TreeView.test.tsx Removed tests that relied on the CSS modules feature flag.
.changeset/thick-teams-taste.md Updated changeset for the removal of CSS modules feature flag.

@jonrohan jonrohan enabled auto-merge April 24, 2025 20:47
@jonrohan jonrohan added this pull request to the merge queue Apr 25, 2025
Merged via the queue into main with commit c1ea6cf Apr 25, 2025
48 checks passed
@jonrohan jonrohan deleted the css_modules_feature_flag_treeview branch April 25, 2025 03:17
@primer primer bot mentioned this pull request Apr 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@francinelucca francinelucca francinelucca approved these changes

@hectahertz hectahertz Awaiting requested review from hectahertz hectahertz is a code owner automatically assigned from primer/engineer-reviewers

@joshblack joshblack Awaiting requested review from joshblack

Assignees
No one assigned
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonrohan @francinelucca