Skip to content

chore(TreeView): Remove the CSS modules feature flag from the TreeView component #5934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 25, 2025
Merged

chore(TreeView): Remove the CSS modules feature flag from the TreeView component #5934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6248224
Remove the CSS modules feature flag
jonrohan Apr 16, 2025
af94514
Add changeset
jonrohan Apr 16, 2025
fb2d5b5
Merge branch 'main' into css_modules_feature_flag_treeview
jonrohan Apr 22, 2025
9cf417c
Merge branch 'main' into css_modules_feature_flag_treeview
jonrohan Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/thick-teams-taste.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': minor
---

Remove the CSS modules feature flag from the TreeView component
13 changes: 0 additions & 13 deletions packages/react/src/TreeView/TreeView.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import React from 'react'
import {ThemeProvider} from '../ThemeProvider'
import type {SubTreeState} from './TreeView'
import {TreeView} from './TreeView'
import {FeatureFlags} from '../FeatureFlags'

jest.useFakeTimers()

Expand Down Expand Up @@ -1651,20 +1650,8 @@ describe('CSS Module Migration', () => {
<TreeView.Item id="item-3">Item 3</TreeView.Item>
</TreeView>
)
const FeatureFlagElement = () => {
return (
<FeatureFlags
flags={{
primer_react_css_modules_ga: true,
}}
>
<TreeViewTestComponent />
</FeatureFlags>
)
}

// Testing on the second child element because the first child element is visually hidden
expect(render(<TreeViewTestComponent />).container.children[1]).toHaveClass('test-class-name')
expect(render(<FeatureFlagElement />).container.children[1]).toHaveClass('test-class-name')
})
})
Loading
Loading