Skip to content

Korean Translation of Web Editor #1632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yinhwa opened this issue Oct 15, 2020 · 7 comments · Fixed by #1784
Closed

Korean Translation of Web Editor #1632

yinhwa opened this issue Oct 15, 2020 · 7 comments · Fixed by #1784

Comments

@yinhwa
Copy link
Contributor

yinhwa commented Oct 15, 2020

Currently in progress with @kangashley & @yinhwa


Hi @catarak, @ghalestrilo ! I'm trying to add Korean translation to the web editor to increase the editor's lingual accessibility to Korean speakers. My particular concern is on some dozens of older adults in Korea that I'll be having p5.js workshop with on November, but it certainly will be helpful for the language group in general both in and out the country.

I have checked in with @ghalestrilo if there'd be any conflicts on the mobile UI if I add new translation, and Thales's told me it will work automatically :) I've also noticed that [Spanish translation] was successfully added a couple months ago!🎉

And yet, I would like to ask if it will be alright for me to start working on it by now; and if adding translation was part of the maintenance plan. If everything's fine, I'm planning to have it done before the Week 2 of November, since I'm having the workshop on Week 3-4 and afterwards.

Please let me know your opinion!
Thank you :)

Nature of issue?

  • Existing feature enhancement
  • New feature request

Feature enhancement details:

  • Add Korean translation of log in/sign up; menus; (+examples if possible)

New feature details:

  • Add "Korean" button on the top right corner
@welcome
Copy link

welcome bot commented Oct 15, 2020

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

@catarak
Copy link
Member

catarak commented Oct 15, 2020

Hey @yinhwa! I'm super excited you want to work on this. Now that @oruburos did the first translation, the new ones should be simpler. He made a translation guide which should help you. Let me know if you have any questions! Also, feel free to open multiple pull requests to complete this, as now that there are releases (like v1.1.1, etc), things that are merged into develop are not immediately merged to production.

@yinhwa
Copy link
Contributor Author

yinhwa commented Oct 16, 2020

@catarak thank you Cassie!!! :) wish my best luck with the new releases🎇🎉 p5 web editor rox yay!

@oruburos
Copy link
Collaborator

Hey @yinhwa and @catarak , good to see people working on this. Also, please check #1638 . Good luck.

@yinhwa
Copy link
Contributor Author

yinhwa commented Oct 18, 2020

Thanks @oruburos for letting me know and your guides on Koji's Issue 😁 Also excited for @koji 's Japanese translation!

@koji
Copy link
Contributor

koji commented Oct 18, 2020

@yinhwa
Actually, your issue helped me to start working on my issue!
Thank you for opening this!

@yinhwa
Copy link
Contributor Author

yinhwa commented Oct 21, 2020

@kangashley is joining this translation 🥰 yay

yinhwa added a commit to yinhwa/p5.js-web-editor that referenced this issue Oct 24, 2020
yinhwa added a commit to yinhwa/p5.js-web-editor that referenced this issue Mar 2, 2021
yinhwa added a commit to yinhwa/p5.js-web-editor that referenced this issue Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants