Skip to content

initial Korean Translation of Web Editor #1784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 6, 2023
Merged

Conversation

yinhwa
Copy link
Contributor

@yinhwa yinhwa commented Mar 2, 2021

Fixes #1632

  1. Newly added translations > locales > ko folder with translation.json file
  2. Edited Nav.jsx and i18n.js

Thank you ☺☺

@welcome
Copy link

welcome bot commented Mar 2, 2021

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@release-com
Copy link

release-com bot commented Mar 2, 2021

Release Environments

p5.js-web-editor
app-ted78f5-p5-js-web-editor.releaseapp.io

@catarak
Copy link
Member

catarak commented Mar 9, 2021

This is so rad! Let me know when it's ready to be reviewed. The cool think about the Release integration is that you can use the above link when you're ready to get some feedback from folks using the p5.js Editor!

@yinhwa
Copy link
Contributor Author

yinhwa commented Mar 11, 2021

@catarak Thank you Cassie for the kind guideline 🤩 yes, the releaseapp was so much helpful in testing out how the editor in Korean will be looking like in the end ! (And needless to mention, I'm looking so much forward to the newly updated mobile UI! they look amazing and even more accessible!)

I was thinking if it's ok with you, maybe the codes can be reviewed for now, so we can make sure that the basic set ups for the i18n is working alright? Then, I'll continue translating on the rest of the ko-relevant json files. Pls let me know what you think :) Thank you!

@catarak
Copy link
Member

catarak commented Mar 11, 2021

The code looks good to me! Switching to and from Korean is also working for me.

@yinhwa
Copy link
Contributor Author

yinhwa commented Mar 12, 2021

Thank you @catarak for the quick review! I'll continue working on the translation then :) Should I close this request and then re-open it with more translation added, or can it be merged to develop branch now? Pls lemme know what's comfortable for you!

@catarak
Copy link
Member

catarak commented Mar 12, 2021

You can keep adding to this PR! As you push more changes to your branch, it will get added to this PR. I'll merge it in when the translation is finished.

@raclim
Copy link
Collaborator

raclim commented Nov 17, 2022

Hi @yinhwa! Just wanted to check-in on the status of these translations, or if you feel like it's ready to be merged, thanks! :)

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far, it looks great to me! I'm going to merge in the work that's been done for now!

@raclim raclim merged commit 27988e1 into processing:develop Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Korean Translation of Web Editor
3 participants