-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
initial Korean Translation of Web Editor #1784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
Release Environmentsp5.js-web-editor |
This is so rad! Let me know when it's ready to be reviewed. The cool think about the Release integration is that you can use the above link when you're ready to get some feedback from folks using the p5.js Editor! |
@catarak Thank you Cassie for the kind guideline 🤩 yes, the releaseapp was so much helpful in testing out how the editor in Korean will be looking like in the end ! (And needless to mention, I'm looking so much forward to the newly updated mobile UI! they look amazing and even more accessible!) I was thinking if it's ok with you, maybe the codes can be reviewed for now, so we can make sure that the basic set ups for the i18n is working alright? Then, I'll continue translating on the rest of the |
The code looks good to me! Switching to and from Korean is also working for me. |
Thank you @catarak for the quick review! I'll continue working on the translation then :) Should I close this request and then re-open it with more translation added, or can it be merged to |
You can keep adding to this PR! As you push more changes to your branch, it will get added to this PR. I'll merge it in when the translation is finished. |
Hi @yinhwa! Just wanted to check-in on the status of these translations, or if you feel like it's ready to be merged, thanks! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far, it looks great to me! I'm going to merge in the work that's been done for now!
Fixes #1632
translations > locales > ko
folder withtranslation.json
fileNav.jsx
andi18n.js
Thank you ☺☺