Switch linter to double quotes #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this. Should we also make fixes to |
|
Since the test files already use double quotes, I'd prefer to handle any test changes in a follow up if that's ok with you :) |
|
Sure, sounds good. |
stasm
approved these changes
Feb 21, 2018
|
🎉 |
unclenachoduh
added a commit
to unclenachoduh/fluent.js
that referenced
this pull request
Aug 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in a day when I crafted the list of eslint rules we use I made a mistake - settled on single quotes.
Nobody likes that, and its incompatible with Mozilla eslinting rules. Let's fix it.
This patch exclusively focuses on quotes because that's the only incompatibility between us and mozilla-central. We may want to further align our rules with mozilla ruleset, but that'll be optional and may be worth more discussions.
I basically ran
eslint **/src --fix.