Restrict variant keys #157 #268
Conversation
There was a problem hiding this comment.
Thanks, @unclenachoduh. There are some extra files included in this PR which look like they were accidentally added with git add. Otherwise, the change looks good technically.
I can't merge this just yet, however. The decision to make this change to the Fluent Syntax Spec has not yet been made. I'm still gathering feedback on the proposal in projectfluent/fluent#127. Please comment there if you think this proposal should be accepted.
|
Ah, yes. I just removed those files from the PR. I was aware that this PR might not be able to merge. I took it as an opportunity to get to know fluent.js. Hopefully this PR becomes useful if the decision regarding that issue goes in this direction. Thanks, Stas. |
exit
Outdated
| [32m+[m[32m // });[m | ||
| [m | ||
| test("variant key number", function() {[m | ||
| const input = ftl`[m |
There was a problem hiding this comment.
This file was added by accident, please remove.
There was a problem hiding this comment.
Let's merge this into zeroseven. We'll need to add a few more tests from the reference parser, but it's going to be easier to do once other changes have been implemented. Thanks, @unclenachoduh, for the PR!
Restrict variant keys to Identifiers and NumberLiterals #157