Skip to content

Remove FluentBundle.addMessages #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2019
Merged

Remove FluentBundle.addMessages #404

merged 1 commit into from
Jul 23, 2019

Conversation

stasm
Copy link
Contributor

@stasm stasm commented Jul 23, 2019

Fix #328.

@stasm stasm requested a review from Pike July 23, 2019 17:40
Pike
Pike approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@Pike Pike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was giving the mcx an eye in a review a while back.

One nit question, r=me either way.

fluent/test/context_test.js Outdated
suiteSetup(function() {
bundle = new FluentBundle('en-US', { useIsolating: false });
bundle.addMessages(ftl`
let resource = new FluentResource(ftl`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this resource?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you asking whether this should be a separate variable?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Yeah, I can inline this one as well. Thanks.

@stasm stasm force-pushed the remove-addMessages branch from 4d2a366 to e7f0191 Compare July 23, 2019 18:14
@stasm stasm merged commit 0208197 into projectfluent:release-fluent-zero-thirteen Jul 23, 2019
@stasm stasm mentioned this pull request Jul 23, 2019
Closed
@stasm stasm deleted the remove-addMessages branch July 30, 2019 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pike Pike Pike approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stasm @Pike