Skip to content

Remove FluentBundle.addMessages #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2019
Merged

Remove FluentBundle.addMessages #404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions fluent-dom/test/dom_localization_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import assert from "assert";
import { FluentBundle } from "../../fluent/src/index";
import { FluentBundle, FluentResource } from "../../fluent/src/index";
import DOMLocalization from "../src/dom_localization";

async function* mockGenerateMessages(resourceIds) {
const bundle = new FluentBundle(["en-US"]);
bundle.addMessages("key1 = Key 1");
const resource = new FluentResource("key1 = Key 1");
bundle.addResource(resource);
yield bundle;
}

Expand Down
5 changes: 3 additions & 2 deletions fluent-dom/test/localization_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import assert from "assert";
import { FluentBundle } from "../../fluent/src/index";
import { FluentBundle, FluentResource } from "../../fluent/src/index";
import Localization from "../src/localization";

async function* mockGenerateMessages(resourceIds) {
const bundle = new FluentBundle(["en-US"]);
bundle.addMessages("key1 = Key 1");
const resource = new FluentResource("key1 = Key 1");
bundle.addResource(resource);
yield bundle;
}

Expand Down
10 changes: 5 additions & 5 deletions fluent-react/test/localized_change_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from 'react';
import assert from 'assert';
import { shallow } from 'enzyme';
import { FluentBundle } from '../../fluent/src';
import { FluentBundle, FluentResource } from '../../fluent/src';
import ReactLocalization from '../src/localization';
import { Localized } from '../src/index';

Expand All @@ -10,9 +10,9 @@ suite('Localized - change bundles', function() {
const bundle1 = new FluentBundle();
const l10n = new ReactLocalization([bundle1]);

bundle1.addMessages(`
bundle1.addResource(new FluentResource(`
foo = FOO
`);
`));

const wrapper = shallow(
<Localized id="foo">
Expand All @@ -26,9 +26,9 @@ foo = FOO
));

const bundle2 = new FluentBundle();
bundle2.addMessages(`
bundle2.addResource(new FluentResource(`
foo = BAR
`);
`));

l10n.setBundles([bundle2]);

Expand Down
18 changes: 9 additions & 9 deletions fluent-react/test/localized_fallback_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from 'react';
import assert from 'assert';
import { shallow } from 'enzyme';
import { FluentBundle } from '../../fluent/src';
import { FluentBundle, FluentResource } from '../../fluent/src';
import ReactLocalization from '../src/localization';
import { Localized } from '../src/index';

Expand All @@ -10,9 +10,9 @@ suite('Localized - fallback', function() {
const bundle1 = new FluentBundle();
const l10n = new ReactLocalization([bundle1]);

bundle1.addMessages(`
bundle1.addResource(new FluentResource(`
foo = FOO
`);
`));

const wrapper = shallow(
<Localized id="foo">
Expand All @@ -31,12 +31,12 @@ foo = FOO
const bundle2 = new FluentBundle();
const l10n = new ReactLocalization([bundle1, bundle2]);

bundle1.addMessages(`
bundle1.addResource(new FluentResource(`
not-foo = NOT FOO
`);
bundle2.addMessages(`
`));
bundle2.addResource(new FluentResource(`
foo = FOO
`);
`));

const wrapper = shallow(
<Localized id="foo">
Expand All @@ -54,9 +54,9 @@ foo = FOO
const bundle1 = new FluentBundle();
const l10n = new ReactLocalization([bundle1]);

bundle1.addMessages(`
bundle1.addResource(new FluentResource(`
not-foo = NOT FOO
`);
`));

const wrapper = shallow(
<Localized id="foo">
Expand Down
Loading