Skip to content

Add shell and encoding options to exec #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Conversation

thomashoneyman
Copy link
Contributor

Description of the change

The Node child process API supports shell and encoding arguments for exec, as well as for execFile. The latter accepts a boolean possibility for shell, which I've omitted for ergonomic reasons; it defaults to false but setting any shell string will set it to true, so it's not strictly necessary to support both forms of the option.


Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@thomashoneyman
Copy link
Contributor Author

cc: @colinwahl; we're using this in a project and noticed these options are missing upstream.

@JordanMartinez
Copy link
Contributor

JordanMartinez commented Jul 12, 2021

@thomashoneyman I noticed that execFile does include a shell argument, but it also allows one to pass in a Boolean value in addition to the normal String value.

Might help if I read through the rest of that comment. Yeah, I agree about the ergonomics. I don't think anyone will be using that anytime soon and if they do, they can open an issue/PR.

Copy link
Contributor

@JordanMartinez JordanMartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants