Added shell and timeout, killSignal options to spawn functions #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyb
requested changes
Feb 16, 2023
Comment on lines
+269
to
+270
| , shell :: Maybe String | ||
| , timeout :: Maybe Number |
There was a problem hiding this comment.
The types for these probably aren't quite ideal - I'd suggest using Milliseconds for timeout, and shell perhaps needs a new sum type that covers the true argument. I've actually never used anything but true, thought it was a mistake here until I checked the node docs!
|
Superceded by #46. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
child_process.spawnsupportsshellandtimeout,killSignaloptionsThe
shellimplementation was referenced at #29 (comment).Checklist:
Linked any existing issues or proposals that this pull request should closeUpdated or added relevant documentationAdded a test for the contribution (if applicable)