Skip to content

tests: always disable on the nogil build #5701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 29, 2025

Conversation

henryiii
Copy link
Collaborator

Description

  • docs: fix docs on visibility preset hidden
  • tests: always disable on the nogil build

See #5700, this isn't actually skipping. Let's just always disable it on the free-threaded build.

Also a small docs fix mentioned in #5696.

@henryiii henryiii force-pushed the henryiii/chore/moreft branch from cee4851 to 12e8dff Compare May 27, 2025 22:38
@henryiii henryiii force-pushed the henryiii/chore/moreft branch from 3729032 to 4ed8395 Compare May 27, 2025 22:41
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be helpful in the future to explain in a sentence or two why we're making the change in test_gil_scoped.py (info currently only under PR 5701, not easy to find).

@henryiii henryiii merged commit a18b1bc into pybind:master May 29, 2025
129 of 130 checks passed
@henryiii henryiii deleted the henryiii/chore/moreft branch May 29, 2025 03:33
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label May 29, 2025
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants