Skip to content

tests: always disable on the nogil build #5701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 29, 2025
Merged

tests: always disable on the nogil build #5701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8e0ea75
docs: fix docs on visibilty preset hidden
henryiii May 27, 2025
4ed8395
tests: always disable on the nogil build
henryiii May 27, 2025
4c71bea
style: pre-commit fixes
pre-commit-ci[bot] May 27, 2025
77840a8
docs: mention skip reason in comment
henryiii May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tests/test_gil_scoped.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import multiprocessing
import sys
import sysconfig
import threading
import time

Expand All @@ -10,8 +11,11 @@
import env
from pybind11_tests import gil_scoped as m

# Test collection seems to hold the gil
# These tests have rare flakes in nogil; since they
# are testing the gil, they are skipped at the moment.
skipif_not_free_threaded = pytest.mark.skipif(
not getattr(sys, "_is_gil_enabled", lambda: True)(),
sysconfig.get_config_var("Py_GIL_DISABLED"),
reason="Flaky without the GIL",
)

Expand Down
2 changes: 1 addition & 1 deletion tools/pybind11Config.cmake.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ you can either use the basic targets, or use the FindPython tools:
target_link_libraries(MyModule2 PUBLIC pybind11::headers)
set_target_properties(MyModule2 PROPERTIES
INTERPROCEDURAL_OPTIMIZATION ON
CXX_VISIBILITY_PRESET ON
CXX_VISIBILITY_PRESET hidden
VISIBILITY_INLINES_HIDDEN ON)

If you build targets yourself, you may be interested in stripping the output
Expand Down