Skip to content

Test NumPy 1.12 and latest in both Travis and tox #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

nils-werner
Copy link
Contributor

I have now run into issues with NumPy 1.12 twice: #71 #78. Maybe it makes sense to test multiple Python versions and multiple NumPy versions?

This PR creates a testmatrix in both Travis and tox that tests all combinations of

  • Python 2.7
  • Python 3.6

and

  • NumPy 1.12.0
  • NumPy latest

In tox you can run a specific test on a version combination using

tox -e py36-numpy12 -- -k testname

for testname on Python 3.6 and NumPy 1.12.0

@hameerabbasi
Copy link
Collaborator

Since we're making extensive use of the __array_ufunc__ interface which was introduced in Numpy 1.13, we should require Numpy 1.13.0 rather than supporting legacy versions. It should be okay, since most packages (at least in the Anaconda ecosystem) have been updated to support Numpy 1.13.

@nils-werner
Copy link
Contributor Author

Wait but in #71 it was the other way round, no? :-)

@hameerabbasi
Copy link
Collaborator

Merging #72 might help fix this... I'll re-run once that's merged. Otherwise I'm just in favor of dropping Numpy 1.12 support.

#71 was different because it was a minor behavioral change leading to a test failure. Here, it's a whole paradigm shift between how Numpy 1.12 and 1.13 handle operations in general.

@hameerabbasi
Copy link
Collaborator

We're no longer supporting Numpy 1.12 (see #84 for all the benefits).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants