workaround for failing dask zeros_like #4505
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcherian
reviewed
Oct 12, 2020
| @@ -101,6 +101,8 @@ def isnull(data): | |||
| return isnan(data) | |||
| elif issubclass(scalar_type, (np.bool_, np.integer, np.character, np.void)): | |||
| # these types cannot represent missing values | |||
| if hasattr(data, "_meta"): | |||
There was a problem hiding this comment.
We have is_duck_dask_array somewhere. But I'm not sure if pint (for e.g.) forwards the _meta property. cc @keewis
There was a problem hiding this comment.
pint will forward to the wrapped array using __getattr__ if it doesn't define the attribute itself, so we should be good. I'm not sure if other duck dask arrays do that, though (are there any rules/conventions for this?).
|
This might get fixed upstream dask/dask#6731 Also my idea does not seem to work... |
|
This was fixed upstream. There are new failures but I am pretty sure they are unrelated as dask is not involved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isort . && black . && mypy . && flake8whats-new.rst