Skip to content

workaround for failing dask zeros_like #4505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

workaround for failing dask zeros_like #4505

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions xarray/core/duck_array_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,8 @@ def isnull(data):
return isnan(data)
elif issubclass(scalar_type, (np.bool_, np.integer, np.character, np.void)):
# these types cannot represent missing values
if hasattr(data, "_meta"):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have is_duck_dask_array somewhere. But I'm not sure if pint (for e.g.) forwards the _meta property. cc @keewis

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pint will forward to the wrapped array using __getattr__ if it doesn't define the attribute itself, so we should be good. I'm not sure if other duck dask arrays do that, though (are there any rules/conventions for this?).

data._meta = None # workaround for GH4502
return zeros_like(data, dtype=bool)
else:
# at this point, array should have dtype=object
Expand Down