Skip to content

Better support for anaconda virtualenvs #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cpaulik opened this issue Nov 3, 2015 · 13 comments
Closed

Better support for anaconda virtualenvs #103

cpaulik opened this issue Nov 3, 2015 · 13 comments

Comments

@cpaulik
Copy link
Contributor

cpaulik commented Nov 3, 2015

See the discussion in pyenv/pyenv#467 for reference

@yyuu
Copy link
Collaborator

yyuu commented Nov 4, 2015

Opened some of PRs to improve interoperability to Anaconda/Miniconda. As a side effect, I believe this would also sophisticate the handling of virtual environments created by virtualenv/pyvenv.

@thomasjo
Copy link

thomasjo commented Nov 4, 2015

@yyuu Please let me know if there's anything specific I can help out with regards to testing these changes 🙇

@cpaulik
Copy link
Contributor Author

cpaulik commented Nov 4, 2015

@yyuu Thanks, This looks like a very good set of changes.

@yyuu
Copy link
Collaborator

yyuu commented Nov 5, 2015

I'd like to ask you guys to test with your environments including 3rd party tools for interoperability. I'll update this once I wrote missing tests and merge them into master branch....

@yyuu
Copy link
Collaborator

yyuu commented Nov 5, 2015

I've finished merging all of them. Please give it a try, and let me know if there is a problem.

@cpaulik
Copy link
Contributor Author

cpaulik commented Nov 5, 2015

I've tested all the things that gave me problems before and they work like a charm now. Thanks a lot ❤️

@cpaulik cpaulik closed this as completed Nov 5, 2015
@cpaulik
Copy link
Contributor Author

cpaulik commented Nov 5, 2015

I've found one problem that might bite some users.

running source activate testenv does not work as it would in anaconda but closes the console

Would it be possible to make the activate shim behave like the activate script of anaconda?

Normally I would of course use pyenv activate but I ran into this because of a script that uses source activate to activate an environment. Which means that setup scripts which work everywhere break if a user has pyenv installed.

@cpaulik cpaulik reopened this Nov 5, 2015
@yyuu
Copy link
Collaborator

yyuu commented Nov 6, 2015

Umm. It's difficult to hook the invocation of source activate in pyenv.... I'm trying to look for some workaround for it, but none of working code is ready for now.

This would be a issue living with Anaconda/Miniconda, but it must not be a new issue introduced by the PRs.

@yyuu
Copy link
Collaborator

yyuu commented Nov 6, 2015

Fortunately there is pyenv-virtualenv-init. Manipulating PATH in it might be working for the issue. I don't like to do such thing in pyenv, but I haven't yet found any other solutions. Basically I really hate installing source scripts in PATH 😞

@yyuu
Copy link
Collaborator

yyuu commented Nov 6, 2015

Opened a PR for source activate issue.

#108

@cpaulik
Copy link
Contributor Author

cpaulik commented Nov 6, 2015

@yyuu Thanks for considering it. I can understand your aversion to installing source scripts in PATH. I tested the PR and it works as expected. Also activating an environment using source and deactivating it with pyenv deactivate works as expected.

@yyuu
Copy link
Collaborator

yyuu commented Nov 7, 2015

Is there still something need to be done?

@cpaulik
Copy link
Contributor Author

cpaulik commented Nov 7, 2015

After a day of testing this works very well now. Thank you.

@cpaulik cpaulik closed this as completed Nov 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants