-
-
Notifications
You must be signed in to change notification settings - Fork 422
Better support for anaconda virtualenvs #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Opened some of PRs to improve interoperability to Anaconda/Miniconda. As a side effect, I believe this would also sophisticate the handling of virtual environments created by virtualenv/pyvenv. |
@yyuu Please let me know if there's anything specific I can help out with regards to testing these changes 🙇 |
@yyuu Thanks, This looks like a very good set of changes. |
I'd like to ask you guys to test with your environments including 3rd party tools for interoperability. I'll update this once I wrote missing tests and merge them into |
I've finished merging all of them. Please give it a try, and let me know if there is a problem. |
I've tested all the things that gave me problems before and they work like a charm now. Thanks a lot ❤️ |
I've found one problem that might bite some users. running Would it be possible to make the Normally I would of course use |
Umm. It's difficult to hook the invocation of This would be a issue living with Anaconda/Miniconda, but it must not be a new issue introduced by the PRs. |
Fortunately there is pyenv-virtualenv-init. Manipulating PATH in it might be working for the issue. I don't like to do such thing in pyenv, but I haven't yet found any other solutions. Basically I really hate installing source scripts in PATH 😞 |
Opened a PR for |
@yyuu Thanks for considering it. I can understand your aversion to installing source scripts in PATH. I tested the PR and it works as expected. Also activating an environment using |
Is there still something need to be done? |
After a day of testing this works very well now. Thank you. |
See the discussion in pyenv/pyenv#467 for reference
The text was updated successfully, but these errors were encountered: