Create virtualenv inside envs directory as similar as Anaconda
#107
Conversation
| VIRTUALENV_PATH="${PYENV_ROOT}/versions/${VIRTUALENV_NAME}" | ||
| VIRTUALENV_PATH="${PYENV_ROOT}/versions/${VERSION_NAME}/envs/${VIRTUALENV_NAME}" | ||
|
|
||
| COMPAT_VIRTUALENV_PATH="${PYENV_ROOT}/versions/${VIRTUALENV_NAME}" # TODO: create symlink? |
There was a problem hiding this comment.
TODO: create symlink?
👍
Also two symlinks or only env-${VIRTUALENV_NAME} would be nice (regarding the namespace/sorting aspect).
Edit: done below (https://github.com/yyuu/pyenv-virtualenv/pull/107/files#diff-bd69978b5a6129153b41981ec977a3d5R436) already, so the TODO seems obsolete.
There was a problem hiding this comment.
The var should be prefixed with PYENV_.
There was a problem hiding this comment.
Personally, I prefer simple naming of ${VIRTUALENV_NAME} than env-${VIRTUALENV_NAME}. It would be better from the point of view of backward compatibility. I think naming of the virtualenv would be a matter of users, and tool should not do mangling as much as possible....
There was a problem hiding this comment.
COMPAT_VIRTUALENV_PATH is a shell variable, not an environment variable. So, we don't have to be severe about naming convention, I believe.
There was a problem hiding this comment.
The TODO message was just lying.... I'll remove it.
|
Nice! |
Create virtualenv inside `envs` directory as similar as Anaconda
This changes the installation path of virtualenv as similar as Anaconda/Miniconda. This would be reasonable since every virtualenvs are actually depending on its source version, and they cannot work alone.
This is a kind of breaking change. To mitigate the migration cost, I prepared a symlink of
COMPAT_VIRTUALENV_PATHfor backward compatibility.