-
-
Notifications
You must be signed in to change notification settings - Fork 292
Remove setuptools dependencie, improve release process #1030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
db8b0d6
to
4a670e8
Compare
cdce8p
reviewed
Jun 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like tbump
might actually work 😉 I left some comments. This one does replace #1018, right?
b369d68
to
4573b39
Compare
4573b39
to
fdce9f5
Compare
fdce9f5
to
2ce5ef1
Compare
cdce8p
reviewed
Jun 15, 2021
cdce8p
reviewed
Jun 15, 2021
166ac23
to
afb8e94
Compare
Next step, same thing in pylint ! :) |
This was referenced Jul 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This MR replace setuptools_scm by tbump and a small script. This should permit to remove the setuptools hidden dependencie and facilitate the release process. Next step is to add the release itself in github actions.
Type of Changes
Related Issue
Closes #1016