Skip to content

Create a file for inference tip #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

Pierre-Sassoulas
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas commented Jun 15, 2021

Description

This permit to not have to import wrapt directly in __init__.py

It's a dependency and we want to be able to use attr: astroid.__version__ for packaging without installing dependencies first.

Type of Changes

Type
🔨 Refactoring

Related Issue

#1030

This permit to not have to import wrapt in __init__.py

It's a dependencie and we want to be able to use attr: astroid.__version__ for packaging without installing depdencies first.
@Pierre-Sassoulas Pierre-Sassoulas added task Maintenance Discussion or action around maintaining astroid or the dev workflow labels Jun 15, 2021
@Pierre-Sassoulas Pierre-Sassoulas requested a review from cdce8p June 15, 2021 16:05
Copy link
Member

@cdce8p cdce8p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I just ran the pylint tests and everything seems to work as expected.

@cdce8p cdce8p added the pylint-tested PRs that don't cause major regressions with pylint label Jun 15, 2021
@cdce8p cdce8p added this to the 2.6.0 milestone Jun 15, 2021
@Pierre-Sassoulas Pierre-Sassoulas merged commit 778d181 into master Jun 15, 2021
@Pierre-Sassoulas Pierre-Sassoulas deleted the create-file-for-inference-tip branch June 15, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining astroid or the dev workflow pylint-tested PRs that don't cause major regressions with pylint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants