Skip to content

Fix re brain on 3.11 #1515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 22, 2022
Merged

Fix re brain on 3.11 #1515

merged 8 commits into from
Apr 22, 2022

Conversation

DanielNoord
Copy link
Collaborator

Steps

  • For new features or bug fixes, add a ChangeLog entry describing what your PR does.
  • Write a good description on what the PR does.

Description

Not sure how we can do this easily with the CI. It's good to add it know to make sure the coverage stays as expected.
Only 25 failing tests left to go.

Type of Changes

Type
🐛 Bug fix

Related Issue

@coveralls
Copy link

coveralls commented Apr 17, 2022

Pull Request Test Coverage Report for Build 2207023862

  • 5 of 6 (83.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.007%) to 91.496%

Changes Missing Coverage Covered Lines Changed/Added Lines %
astroid/brain/brain_re.py 4 5 80.0%
Totals Coverage Status
Change from base Build 2206952300: -0.007%
Covered Lines: 9091
Relevant Lines: 9936

💛 - Coveralls

Copy link
Member

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! So is the plan to let the pipeline fail until numpy can be built on 3.11?

@DanielNoord
Copy link
Collaborator Author

Great! So is the plan to let the pipeline fail until numpy can be built on 3.11?

I tested locally without numpy installed, which passes the tests. Should we do that for now? Pin numpy to not install on 3.11?

@jacobtylerwalls
Copy link
Member

As long as we put it on a todo somewhere to turn it back on!

@DanielNoord
Copy link
Collaborator Author

Extracted CI changes into #1517 to make the diff a bit cleaner.

Copy link
Member

@cdce8p cdce8p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DanielNoord!

@cdce8p cdce8p merged commit d38d7e9 into pylint-dev:main Apr 22, 2022
@DanielNoord DanielNoord deleted the 3.11 branch April 22, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants