-
-
Notifications
You must be signed in to change notification settings - Fork 292
Enable 3.11
in the CI
#1517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable 3.11
in the CI
#1517
Conversation
Pull Request Test Coverage Report for Build 2206945525
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python 3.11 is still in alpha at this time. Maybe it's better to add it as a separate job for now, instead of using always()
. We can merge that back once the beta has gotten stable enough.
.github/workflows/ci.yaml
Outdated
coverage: | ||
name: tests / process / coverage | ||
runs-on: ubuntu-latest | ||
timeout-minutes: 5 | ||
needs: ["tests-linux"] | ||
needs: ["tests-linux", "tests-linux-alpha"] | ||
if: ${{ always() }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cdce8p This remains necessary for the coverage to include 3.11
which would be good for any changes we introduce to fix regression with that version. I have removed it from the windows job though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure that is all that useful. The coverage is merged anyway, so the only thing we would get would be the lines with PY311_PLUS
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that would still be helpful. For example, more "risky" PRs such as #1513 would probably be less risky if we know coverage is okay.
.github/workflows/ci.yaml
Outdated
coverage: | ||
name: tests / process / coverage | ||
runs-on: ubuntu-latest | ||
timeout-minutes: 5 | ||
needs: ["tests-linux"] | ||
needs: ["tests-linux", "tests-linux-alpha"] | ||
if: ${{ always() }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure that is all that useful. The coverage is merged anyway, so the only thing we would get would be the lines with PY311_PLUS
.
.github/workflows/ci.yaml
Outdated
tests-windows-alpha: | ||
name: tests / run / ${{ matrix.python-version }} / Windows | ||
runs-on: windows-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want / need to test Windows? For almost everything the Linux
test should be enough. Once merged we'll test Windows anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed some minor changes. Looks good now!
]
Steps
Description
Type of Changes
Related Issue
Ref. #1516