Skip to content

Enable 3.11 in the CI #1517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 22, 2022
Merged

Enable 3.11 in the CI #1517

merged 7 commits into from
Apr 22, 2022

Conversation

DanielNoord
Copy link
Collaborator

@DanielNoord DanielNoord commented Apr 17, 2022

]

Steps

  • Write a good description on what the PR does.

Description

Type of Changes

Type
🔨 Refactoring

Related Issue

Ref. #1516

@DanielNoord DanielNoord added this to the 2.12.0 milestone Apr 17, 2022
This was referenced Apr 17, 2022
@coveralls
Copy link

coveralls commented Apr 17, 2022

Pull Request Test Coverage Report for Build 2206945525

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 30 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 91.502%

Files with Coverage Reduction New Missed Lines %
astroid/brain/brain_gi.py 30 23.02%
Totals Coverage Status
Change from base Build 2173689786: 0.0%
Covered Lines: 9088
Relevant Lines: 9932

💛 - Coveralls

Copy link
Member

@cdce8p cdce8p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 3.11 is still in alpha at this time. Maybe it's better to add it as a separate job for now, instead of using always(). We can merge that back once the beta has gotten stable enough.

coverage:
name: tests / process / coverage
runs-on: ubuntu-latest
timeout-minutes: 5
needs: ["tests-linux"]
needs: ["tests-linux", "tests-linux-alpha"]
if: ${{ always() }}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cdce8p This remains necessary for the coverage to include 3.11 which would be good for any changes we introduce to fix regression with that version. I have removed it from the windows job though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure that is all that useful. The coverage is merged anyway, so the only thing we would get would be the lines with PY311_PLUS.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that would still be helpful. For example, more "risky" PRs such as #1513 would probably be less risky if we know coverage is okay.

@DanielNoord DanielNoord requested a review from cdce8p April 17, 2022 18:17
coverage:
name: tests / process / coverage
runs-on: ubuntu-latest
timeout-minutes: 5
needs: ["tests-linux"]
needs: ["tests-linux", "tests-linux-alpha"]
if: ${{ always() }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure that is all that useful. The coverage is merged anyway, so the only thing we would get would be the lines with PY311_PLUS.

Comment on lines 284 to 286
tests-windows-alpha:
name: tests / run / ${{ matrix.python-version }} / Windows
runs-on: windows-latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want / need to test Windows? For almost everything the Linux test should be enough. Once merged we'll test Windows anyway.

@DanielNoord DanielNoord requested a review from cdce8p April 18, 2022 18:15
Copy link
Member

@cdce8p cdce8p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed some minor changes. Looks good now!

@cdce8p cdce8p merged commit 7de83a3 into pylint-dev:main Apr 22, 2022
@DanielNoord DanielNoord deleted the 3.11-2 branch April 22, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants