Skip to content

Bring back updated GLM out of sample prediction notebook #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 28, 2022

Conversation

drbenvincent
Copy link
Contributor

The GLM out of sample notebook by @juanitorduz (originally in PyMC 3) was previously updated by me to v4. This accidentally got removed though. See #460 for more details.

  • This PR brings back the updated notebook, though I have executed this with pymc 5.0.1.
  • I also modified the watermark line to %watermark -n -u -v -iv -w -p pytensor

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@juanitorduz
Copy link
Collaborator

Awesome 🙌!

@drbenvincent
Copy link
Contributor Author

Maybe we can simply remove all reference to the GLM submodule now?

@review-notebook-app
Copy link

review-notebook-app bot commented Dec 28, 2022

View / edit / reply to this conversation on ReviewNB

twiecki commented on 2022-12-28T15:36:37Z
----------------------------------------------------------------

Is this all with subheading? Looks a bit big.


OriolAbril commented on 2022-12-28T15:42:46Z
----------------------------------------------------------------

reviewnb can't be used for checking rendering issues, here is how it actually looks: https://pymcio--486.org.readthedocs.build/projects/examples/en/486/generalized_linear_models/GLM-out-of-sample-predictions.html

Copy link
Member

reviewnb can't be used for checking rendering issues, here is how it actually looks: https://pymcio--486.org.readthedocs.build/projects/examples/en/486/generalized_linear_models/GLM-out-of-sample-predictions.html


View entire conversation on ReviewNB

```

:::{include} ../page_footer.md :::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drbenvincent drbenvincent merged commit 5238dc3 into pymc-devs:main Dec 28, 2022
@drbenvincent drbenvincent deleted the glm-oos branch December 28, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants