Skip to content

Report divergences from JAX samplers #7094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

mohammed052
Copy link
Contributor

@mohammed052 mohammed052 commented Jan 9, 2024

Description

PyMC users are used to getting an immediate report when there are divergences in the standard NUTS sampler. So I added a warning to be printed in case of divergence.

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7094.org.readthedocs.build/en/7094/

Updated pymc/sampling/mcmc.py file to add warning on divergences.
Copy link

welcome bot commented Jan 9, 2024

Thank You Banner
💖 Thanks for opening this pull request! 💖 The PyMC community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines and filled in our pull request template to the best of your ability.

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7bb2ccd) 92.21% compared to head (30a9c14) 92.21%.
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7094   +/-   ##
=======================================
  Coverage   92.21%   92.21%           
=======================================
  Files         101      101           
  Lines       16912    16916    +4     
=======================================
+ Hits        15595    15599    +4     
  Misses       1317     1317           
Files Coverage Δ
pymc/sampling/mcmc.py 87.79% <100.00%> (+0.10%) ⬆️

@ricardoV94
Copy link
Member

ricardoV94 commented Jan 11, 2024

@mohammed052 it seems like this issue was already being worked out in #7051

In this case it should be fine for you to overtake it, but in general you don't want to do that as we will likely give priority to the older PRs. In any case the same comment I did here, applies to your changes: #7051 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report divergences from JAX samplers
2 participants