Skip to content

Run convergence checks when using JAX samplers #7165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Feb 21, 2024

Description

Also:

  • Refactored code to avoid so much duplication
  • Inlined some very short one-use functions
  • Got rid of the many verbose log time statements
  • Always run divergence and treedepth checks in run_convergence_checks

Related Issue

Supersedes the following PRs

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7165.org.readthedocs.build/en/7165/

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: Patch coverage is 97.75281% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 92.32%. Comparing base (2e3ea56) to head (17ff331).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7165      +/-   ##
==========================================
+ Coverage   92.29%   92.32%   +0.02%     
==========================================
  Files         101      101              
  Lines       16947    16904      -43     
==========================================
- Hits        15642    15607      -35     
+ Misses       1305     1297       -8     
Files Coverage Δ
pymc/sampling/mcmc.py 87.61% <100.00%> (-0.11%) ⬇️
pymc/stats/convergence.py 97.43% <100.00%> (+2.65%) ⬆️
pymc/sampling/jax.py 94.09% <97.40%> (+0.98%) ⬆️

Copy link
Member

@twiecki twiecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner.

@ricardoV94 ricardoV94 merged commit a2988c7 into pymc-devs:main Feb 28, 2024
@ricardoV94 ricardoV94 deleted the run_jax_warnings branch February 28, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report divergences from JAX samplers
2 participants