Skip to content

Conversation

ColtAllen
Copy link
Collaborator

@ColtAllen ColtAllen commented Dec 15, 2024

Description

Moving graphviz method from MMM Base to ModelBuilder so that it's also supported in CLV moels.

Related Issue

Checklist

Modules affected

  • MMM
  • CLV

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc-marketing--1284.org.readthedocs.build/en/1284/

@ColtAllen ColtAllen added enhancement New feature or request ModelBuilder Related to the ModelBuilder class and its children labels Dec 15, 2024
@ColtAllen ColtAllen added this to the 0.11.0 milestone Dec 15, 2024
@ColtAllen ColtAllen self-assigned this Dec 15, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added docs Improvements or additions to documentation MMM tests labels Dec 15, 2024
@github-actions github-actions bot added the good first issue Good for newcomers . Doesn't require extensive knowledge of the repo and package label Dec 15, 2024
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.05%. Comparing base (f749419) to head (a5d0cd5).
Report is 136 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1284      +/-   ##
==========================================
+ Coverage   95.03%   95.05%   +0.02%     
==========================================
  Files          42       42              
  Lines        4451     4451              
==========================================
+ Hits         4230     4231       +1     
+ Misses        221      220       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@juanitorduz juanitorduz merged commit 66a3f3c into pymc-labs:main Dec 15, 2024
20 checks passed
@ColtAllen ColtAllen deleted the graphviz_model_builder branch December 17, 2024 10:11
aseyboldt pushed a commit to aseyboldt/pymc-marketing that referenced this pull request Dec 20, 2024
* move graphiz to model_builder and test

* notebook test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers . Doesn't require extensive knowledge of the repo and package MMM ModelBuilder Related to the ModelBuilder class and its children tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

graphviz method for ModelBuilder class

2 participants