Pip lies about log location

[cls]

When using the --log option, Pip saves to the right location, but claims the log is being written to ~/.pip/pip.log, which it isn't. (The undocumented --log-file option does nothing either.)

Pip then throws an exception, but that's issue #219.

[embray]

I don't know why there's a --log and a separate --log-file. When pip prints "Storing complete log to..." it uses the value specified by --log-file which defaults to ~/.pip/pip.log. If a different primary log is specified with --log, the default value for --log-file is not updated.

It seems to me that this is all more confusing than it needs to be. Just make --log-file an alias for --log.

[mihneadb]

I did what @iguananaut said in the 2nd commit of my pull request [1]. The issue of writing to the closed log file is still present.

[1] #580

[qwcode]

closing as --log and --log-file technically work now, but note:

• I/O operation on closed file exception with --log #219 still needs to be fixed
• as for the confusion of having the 2 options and their current behavior, see consolidate --log and --log-file #915

[qwcode]

for anyone who comes to this, let me reply specifically to some of the original description:

When using the --log option, Pip saves to the right location, but claims the log is being written to ~/.pip/pip.log

regardless of using --log, when pip has errors it logs the last session to the default for the hidden option --log-file (~/.pip/pip.log on unix), and prints the message "Storing complete log in /home/qwcode/.pip/pip.log"

So in the case of using --log with an error, you'll see this message, and run into bug #219 (which is a failure to write to the value for --log-file). so, pip is not lying. granted, it's confusing, but clearing that up is #915.

The undocumented --log-file option does nothing either.

It does work, but currently only logs to that when there's problems, and it's not append.