remove basecommand.merge_options() #904
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch removes the error prone step of merging the baseparsers'
options (the 'Generic Options') with those of the subparser. In fact,
commands are already capable of parsing all options present in the
'Generic Options' option group. The option parsing logic is as follows:
Given a command line such as:
'--timeout 5 install --user pkg'
pip.parseopt() returns command 'install' with arguments:
'--timeout 5 --user pkg'
pip.main() executes the above as:
commands['install'](parser).main('--timeout 5 --user pkg', options)
|
Fixes #350 also. 👍 |
ghost
assigned 
| options, cmd_args = parser.parse_args(args) | ||
| # args: ['--timeout=5', 'install', '--user', 'INITools'] | ||
| # cmd_args: ['install', '--user', 'INITools'] | ||
| # note: parser calls disable_interspersed_args() |
There was a problem hiding this comment.
Are these comments needed?
There was a problem hiding this comment.
It was good for me, because in the bottom part there is:
args.remove(cmd_args[0])
cmd_args = args # --timeout=5 --user INITools
That is a complement to the first comments.
|
included in PR #1202 |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #70.