I need to add tests for a few PRs I've made

[pradyunsg]

Tracking issue so that I don't forget to write tests for

• Improve Error Messages on EnvironmentErrors when installing #5239 (tracked by Add tests for create_env_error_message #7250)
• Reorder conditionals to deal with installed VCS requirements #5280
• Move Windows protection check to specific commands #5312
• Remove trailing os.sep to avoid false negatives #5293

[cjerdonek]

Hmm, IMHO tests should really be added when the code is first added. PR #5293 is another one with no tests (for issue #5316).

[pradyunsg]

IMHO tests should really be added when the code is first added.

Agreed. For the original issue PR, I was short on time (exams ongoing) and that was a bug fix needed for 10.0.1. The rest of my PRs, the same reason.

As for #5293, I do think it should have had a test.

[pfmoore]

As @pradyunsg noted, we had limited time and wanted to get 10.0.1 released (there's a deadline for the Python 3.7 final beta that I wanted to hit). I made the call as release manager to put the changes in and follow up with the tests.

[cjerdonek]

Okay. Note that if there is ever another 10.x release branched off the tag rather than master, it will not have the regression tests added later unless they are backported to a 10.x branch for that purpose.

…

On Sat, Apr 21, 2018 at 9:27 AM Paul Moore ***@***.***> wrote: As @pradyunsg <https://github.com/pradyunsg> noted, we had limited time and wanted to get 10.0.1 released (there's a deadline for the Python 3.7 final beta that I wanted to hit). I made the call as release manager to put the changes in and follow up with the tests. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#5277 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVt7pJvfXwMPiFf-eLcg_n3eMAfmaXfks5tq14LgaJpZM4TYyic> .

[pfmoore]

Correct. But our workflow is to release from master, that's where 10.1 will be released from. I don't see why you consider this a significant problem.

[cjerdonek]

I didn’t say it’s a significant problem. I just noted it. There have been unplanned releases not from master in the past, so I think the point is worth noting.

…

On Sat, Apr 21, 2018 at 2:56 PM Paul Moore ***@***.***> wrote: Correct. But our workflow is to release from master, that's where 10.1 will be released from. I don't see why you consider this a significant problem. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#5277 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVt7qq3VHz0LfZ5XpcThomtGnfj7Hkvks5tq6smgaJpZM4TYyic> .

[pradyunsg]

This one is up for grabs, for any contributor who is familiar enough with pip's workflows to not need hand-holding around how to run the tests. Please go ahead and take a look at the PRs to understand what behavior needs to be tested. I'm happy to answer questions/help out with writing / figuring out these tests. :)

[pradyunsg]

Closing this out, since the checklist is complete.