-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Move Windows protection check to specific commands #5312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Windows protection check to specific commands #5312
Conversation
TIL - quickly doing a rebase + a force push with the news files might reduce the build times since CI builds will fail to clone the old commit hash which GitHub tells them "is not longer available". |
Wow, quick work, thanks @pradyunsg. I'll give it a try this evening. |
Sure! :) |
@pfmoore Could you investigate the test failure? I'm not sure what's causing it... |
It's the Windows protection check doing its thing, this is fixed with: diff --git a/tests/functional/test_install.py b/tests/functional/test_install.py
index f6162929..5e6548ec 100644
--- a/tests/functional/test_install.py
+++ b/tests/functional/test_install.py
@@ -47,7 +47,8 @@ def test_pep518_uses_build_env(script, data, original_setuptools):
def test_pep518_with_user_pip(script, virtualenv, pip_src, data):
virtualenv.system_site_packages = True
- script.pip("install", "--ignore-installed", "--user", pip_src)
+ script.pip("install", "--ignore-installed", "--user", pip_src,
+ use_module=True)
system_pip_dir = script.site_packages_path / 'pip'
system_pip_dir.rmtree()
system_pip_dir.mkdir() |
5f0365d
to
3f6a4fb
Compare
Thanks @benoit-pierre! |
I'll add unit tests in a follow up PR. |
Hello! I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the |
Hello! I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the |
b1eb4ac
to
2a061c2
Compare
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Fixes #5311