Move Windows protection check to specific commands

[pradyunsg]

Fixes #5311

[pradyunsg]

TIL - quickly doing a rebase + a force push with the news files might reduce the build times since CI builds will fail to clone the old commit hash which GitHub tells them "is not longer available".

[pfmoore]

Wow, quick work, thanks @pradyunsg. I'll give it a try this evening.

[pradyunsg]

Sure! :)

[pradyunsg]

@pfmoore Could you investigate the test failure?

I'm not sure what's causing it...

[benoit-pierre]

It's the Windows protection check doing its thing, this is fixed with:

diff --git a/tests/functional/test_install.py b/tests/functional/test_install.py
index f6162929..5e6548ec 100644
--- a/tests/functional/test_install.py
+++ b/tests/functional/test_install.py
@@ -47,7 +47,8 @@ def test_pep518_uses_build_env(script, data, original_setuptools):
 
 def test_pep518_with_user_pip(script, virtualenv, pip_src, data):
     virtualenv.system_site_packages = True
-    script.pip("install", "--ignore-installed", "--user", pip_src)
+    script.pip("install", "--ignore-installed", "--user", pip_src,
+               use_module=True)
     system_pip_dir = script.site_packages_path / 'pip'
     system_pip_dir.rmtree()
     system_pip_dir.mkdir()

[pradyunsg]

Thanks @benoit-pierre!

[pradyunsg]

I'll add unit tests in a follow up PR.

[BrownTruck]

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will eligible for code review and hopefully merging!

[BrownTruck]

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will eligible for code review and hopefully merging!

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.