Skip to content

remove pip bundle #1046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

remove pip bundle #1046

wants to merge 1 commit into from

Conversation

qwcode
Copy link
Contributor

@qwcode qwcode commented Jul 13, 2013

remove pip bundle

@pnasrat
Copy link
Contributor

pnasrat commented Jul 13, 2013

Is it clearly marked as deprecated in 1.4 docs and code?

@pnasrat
Copy link
Contributor

pnasrat commented Jul 13, 2013

+1 on this patch with the documentation caveat.

@pfmoore
Copy link
Member

pfmoore commented Jul 13, 2013

Looks like "bundle" isn't even mentioned in the current docs:

grep -i bundle .\docs\*.rst
(no output)

@qwcode
Copy link
Contributor Author

qwcode commented Jul 13, 2013

Is it clearly marked as deprecated in 1.4 docs and code?

what should I do to make it deprecated in 1.4 (before 1.4 goes out)?
add a loud message to "pip bundle" executions?

I'm not familiar with python warnings, but it seems something like this won't show by default for users in py>2.6

warnings.warn("'pip bundle' will be removed in pip v1.5", DeprecationWarning, stacklevel=2)

Looks like "bundle" isn't even mentioned in the current docs:

yea, no docs for pip bundle since the docs rehaul a few months back.

@qwcode
Copy link
Contributor Author

qwcode commented Jul 13, 2013

b1f0146

@dstufft
Copy link
Member

dstufft commented Jul 14, 2013

Here are tickets related to pip bundle that are still open:

#450
#438
#236
#164
#110
#68
#977
#978

They should all probably be closed once bundle is removed.

@dstufft
Copy link
Member

dstufft commented Jul 14, 2013

There's also #165.

@qwcode
Copy link
Contributor Author

qwcode commented Jul 18, 2013

decision to remove bundle support was discussed by pip devs here: https://groups.google.com/forum/#!topic/pypa-dev/sYCJe3tT3Bg

leaving open/un-merged until I can write a cookbook entry that covers an alternative workflow. I want to include a link to that in the notification to all the associated issues.

@nOw2
Copy link

nOw2 commented Jul 30, 2013

There most certainly needs to be an alternative workflow provided - we use bundles to perform releases to production. The 'lack of interest' notice in 1.4 came as a surprise here and I would have contributed fixes had I known nobody else was.

My thoughts are that there needs to be a functionally similar replacement for bundling ready before removing the existing system. Having something that works, no matter if less pretty than preferred, is infinitely better than having nothing.

(FYI, bundles are not just deprecated but also broken in 1.4. The build directories in the bundle cause the new 'existing build directory check' to cause bundle installation to fail. Because of this, I've reverted back to 1.3.1. This also means reverting SVN back to 1.6 due to difficulties with 'pip freeze' and SVN >= 1.7. Pushing back SVN when things like Subclipse only support 1.7 is a lot of work. You can see removing bundles in turn causes an avalanche of gradually more painful problems..!)

@qwcode
Copy link
Contributor Author

qwcode commented Jul 31, 2013

@nOw2 our plan is to add support for command extensions (git style), and then the bundle logic would be moved out to a 3rd party extension (whether we do it or get interested parties to do it). 1.5 is months off, so there's time. Besides the lack of interest/maintenance, it's more (imo) about wanting any "bundle" idea to go through the PEP process first, and then we support that in pip, like what happened with wheel in the last year.

@ionelmc
Copy link
Contributor

ionelmc commented Aug 6, 2013

What's the idea behind the bundle removal in 1.5 ?

Also, seems irresponsible to have serious regressions in 1.4 for bundle installations ...

@qwcode
Copy link
Contributor Author

qwcode commented Aug 6, 2013

@ionelmc no regression in 1.4? just a message about the intention to remove it. see link above to the pypa-dev discussion

@ionelmc
Copy link
Contributor

ionelmc commented Aug 6, 2013

@qwcode: see @nOw2 comment. That's clearly a regression it it worked fine on 1.3.

@qwcode
Copy link
Contributor Author

qwcode commented Aug 6, 2013

@ionelmc, @nOw2 ok, I'll check that case. there's a build dir fix (#1080) in 1.4.1 (to be released tomorrow) that may be the solution.

@qwcode qwcode mentioned this pull request Aug 6, 2013
@qwcode
Copy link
Contributor Author

qwcode commented Aug 6, 2013

Given the feedback here, I think it makes sense to get the extension support and have a 3rd party extension working before merging this.

The main thing that would dissuade me from removing bundle, would be to see a ground swell of people working the issues listed above, adding tests, etc...

@qwcode
Copy link
Contributor Author

qwcode commented Aug 12, 2013

gist link from @ionelmc on bash/wheel approximation of bundle
https://gist.github.com/ionelmc/6215920

@qwcode
Copy link
Contributor Author

qwcode commented Oct 23, 2013

v1.5 is coming up fast, so I don't see this removal happening by then (given that I wasn't going to remove it w/o adding the extension system and having a Proof of Concept 3rd party extension)

I changed the deprecation notice accordingly: e7facfe

@dstufft dstufft mentioned this pull request May 8, 2014
@dstufft dstufft closed this in #1806 May 9, 2014
@ionelmc
Copy link
Contributor

ionelmc commented May 9, 2014

@dstufft worth adding something in the docs about how to replace the bundles ?

eg: https://gist.github.com/ionelmc/6215920

@dstufft
Copy link
Member

dstufft commented May 9, 2014

Yea probably, going to add a new ticket for that so I don't forget.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation kind: backwards incompatible Would be backward incompatible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants