-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Display env vars for pip options in docs #11993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Need to fix errors in CI. I also wonder there should be a link to the environment variable documentation. https://pip.pypa.io/en/stable/topics/configuration/#environment-variables Example rendering, for reviewers: https://pip--11993.org.readthedocs.build/en/11993/cli/pip_install/#options |
Let's get this landed, and then we can improve this in a follow up! :) |
@ctg123 Could you look into the code style checks mentioned in https://results.pre-commit.ci/run/github/1446467/1682204558.lnkhmFhyTr-BUqnOYSGFmw? You can run those checks locally as documented in https://pip.pypa.io/en/stable/development/getting-started/#running-linters |
Hi all, OK I will look into running the CI tests this week. |
@ctg123 looks like beside autoformatting, you'd need to add some typing as well. But feel free to add separate commits, one fix at a time if that's easier. |
This comment was marked as outdated.
This comment was marked as outdated.
Context: this PR was created during https://us.pycon.org/2023/events/mentored-sprints/. It may need somebody to take over and polish the types for linting to pass. This can be done through a separate PR — somebody would need to |
@webknjaz I created a new PR including this and the missing changes. |
Ref #8044