-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Display env vars for pip options in docs #12576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Would you mind referencing @ctg123 as the author in the initial commit as well so he shows up as a contributor? This can be done with
|
Co-authored-by: luismedel <[email protected]>
044188a
to
bbef552
Compare
@luismedel could you use full sentences in the changelog fragment? It'd also be nice to drop the imperative mood since a changelog is less of an instruction list and more like a news digest with what's changed since the previous release. Looking good otherwise! |
8abf0ed
to
f9bbdce
Compare
Thanks. I tried to better clarify the change. What I'm not really sure is how to escape the imperative mood if the message should continue the "This change will..." idiom, as per the guidelines :-( |
Stick to the guidelines - the news entry looks fine to me (with one minor grammar nit). Not using imperative mood for news entries isn't a principle we use on pip. |
Co-authored-by: Paul Moore <[email protected]>
Ah, I didn't realize. Wonder why.. |
@luismedel it's not explicitly called out, but if you look into the old changelogs, most of the entries are full sentences with a trailing period. Might be worth fixing? |
@webknjaz sure! |
Thanks for the PR! |
Close #8044
This PR contains the same changes as #11993 by @ctg123 but with the missing type hints.
I decided to create a new PR to simplify the merge.
Close #11993