Don't attempt to build requirements that don't need to be installed #13363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
requirements_to_install is scheduled for removal together with the legacy resolver, at which point we should be able to use all requirements returned by resolve() unconditionally.
sbidoul
force-pushed
the
fix-source_dir-assert
branch
from
78a270a to
9deead0
Compare
1 task
|
I think |
notatallshaw
approved these changes
Apr 30, 2025
Does seem possible, but I couldn't come up with a reproducer, I would be fine waiting on someone to report a reproducible example before trying to fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requirements_to_installis scheduled for removal together with the legacy resolver, at which point we should be able to use all requirements returned byresolve()unconditionally.fixes #13353
I still need to to look for variants of this problem in the
wheel,lockanddownloadcommands.This indeed only happens with the legacy resolver which can return things such as constraints in the RequirementsSet, and unfortunately the logic to filter these out after resolution is dispersed in several places.
@pfmoore I tentatively assigned this to 25.1, but we may sill decide this is not worth a bugfix release and say that affected users need to stop using the legacy resolver or stick to 25.0.