Use vendored appdirs and patch it to not use win32com

[pradyunsg]

Fixes #4874

[pradyunsg]

Ping?

[pfmoore]

Warning - I just spotted #4000 which is a Unicode-specific fix in our version of appdirs. Before merging this change, it's worth confirming that the vendored appdirs doesn't reintroduce that issue.

[pradyunsg]

Nice spot!

I'll add back that test somewhere and then look into it. :)

[pradyunsg]

I spent a bit of time fiddling around.

I think I'm gonna break this up into 2 PRs, one for disabling win32com on the vendored appdirs and another for switching over to the vendored appdirs.

The reasoning is that I looked at the blame of the current utils.appdirs and it seems like we have more than just #4000 in it. It'll be simpler to break this up.

As an example: this PR currently changes the config directory on Windows to C:\Users\test\AppData\Roaming\pip\pip, which is easy to fix by passing an additional parameter to appdirs, but the point is we didn't catch that, so, yeah, let's do all of that in a separate PR.

---

If this makes sense, I'll close this one and open two new PRs with these changes separated.

[pradyunsg]

Okay. Closing. :)

[ghost]

Isn't the appdirs unicode failure a generic bug that should be reported upstream in accordance with pip policy? I don't think that particular problem is constrained to pip.

[pfmoore]

Agreed. I'd also like to see "don't use pywin32" requested upstream - there's as far as I know never a reason to use it as ctypes is available on all supported Windows versions of Python. I'm happy to carry the patch to remove pywin32 temporarily, but long-term I'd like to see it pushed upstream.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.