Skip to content

Use vendored appdirs and patch it to not use win32com #4945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

pradyunsg
Copy link
Member

Fixes #4874

@pradyunsg pradyunsg added type: maintenance Related to Development and Maintenance Processes skip news Does not need a NEWS file entry (eg: trivial changes) project: vendored dependency Related to a vendored dependency labels Dec 27, 2017
@pradyunsg pradyunsg requested a review from a team December 30, 2017 07:21
@pradyunsg
Copy link
Member Author

Ping?

Copy link
Member

@pfmoore pfmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning - I just spotted #4000 which is a Unicode-specific fix in our version of appdirs. Before merging this change, it's worth confirming that the vendored appdirs doesn't reintroduce that issue.

@pradyunsg
Copy link
Member Author

Nice spot!

I'll add back that test somewhere and then look into it. :)

@pradyunsg
Copy link
Member Author

I spent a bit of time fiddling around.

I think I'm gonna break this up into 2 PRs, one for disabling win32com on the vendored appdirs and another for switching over to the vendored appdirs.

The reasoning is that I looked at the blame of the current utils.appdirs and it seems like we have more than just #4000 in it. It'll be simpler to break this up.

As an example: this PR currently changes the config directory on Windows to C:\Users\test\AppData\Roaming\pip\pip, which is easy to fix by passing an additional parameter to appdirs, but the point is we didn't catch that, so, yeah, let's do all of that in a separate PR.


If this makes sense, I'll close this one and open two new PRs with these changes separated.

@pradyunsg
Copy link
Member Author

Okay. Closing. :)

@pradyunsg pradyunsg closed this Jan 24, 2018
@ghost
Copy link

ghost commented Jan 24, 2018

Isn't the appdirs unicode failure a generic bug that should be reported upstream in accordance with pip policy? I don't think that particular problem is constrained to pip.

@pfmoore
Copy link
Member

pfmoore commented Jan 24, 2018

Agreed. I'd also like to see "don't use pywin32" requested upstream - there's as far as I know never a reason to use it as ctypes is available on all supported Windows versions of Python. I'm happy to carry the patch to remove pywin32 temporarily, but long-term I'd like to see it pushed upstream.

@lock
Copy link

lock bot commented Jun 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation project: vendored dependency Related to a vendored dependency skip news Does not need a NEWS file entry (eg: trivial changes) type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Appdirs vendor should not use win32api
2 participants