Skip to content

Disable vendored appdirs loading C library #4992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pradyunsg
Copy link
Member

Fixes #4874

I've cherry-picked these from #4945.

@pradyunsg pradyunsg added type: enhancement Improvements to functionality project: vendored dependency Related to a vendored dependency labels Jan 24, 2018
@pradyunsg pradyunsg added this to the 10.0 milestone Jan 24, 2018
@pradyunsg pradyunsg self-assigned this Jan 24, 2018
@pradyunsg pradyunsg requested a review from a team January 24, 2018 10:17
@pradyunsg pradyunsg added the skip news Does not need a NEWS file entry (eg: trivial changes) label Jan 24, 2018
Copy link
Member

@pfmoore pfmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pradyunsg pradyunsg merged commit 1ea3f89 into pypa:master Jan 24, 2018
@pradyunsg pradyunsg deleted the vendor/disable-appdirs-loading-c-library branch January 24, 2018 11:05
@pradyunsg pradyunsg restored the vendor/disable-appdirs-loading-c-library branch May 27, 2018 09:38
@pradyunsg pradyunsg deleted the vendor/disable-appdirs-loading-c-library branch May 27, 2018 10:08
costypetrisor added a commit to costypetrisor/setuptools that referenced this pull request Jul 28, 2018
it will import pywin32 if available, which will lock pywin32's dlls and
because of that pywin32 cannot be updated anymore (your pip install
command will fail too)

fix is to apply the same patch as the pip project did in
pypa/pip#4992
costypetrisor added a commit to costypetrisor/appdirs that referenced this pull request Jul 29, 2018
…rn it will import pywin32 if available, which will lock pywin32's dlls and because of that pywin32 cannot be updated anymore (your pip install command will fail too)

fix is to apply the same patch as the pip project did since their version 10.0 in pypa/pip#4992
costypetrisor added a commit to costypetrisor/appdirs that referenced this pull request Jul 29, 2018
…rn it will import pywin32 if available, which will lock pywin32's dlls and because of that pywin32 cannot be updated anymore (your pip install command will fail too)

fix is to apply the same patch as the pip project did since their version 10.0 in pypa/pip#4992
@lock
Copy link

lock bot commented Jun 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation project: vendored dependency Related to a vendored dependency skip news Does not need a NEWS file entry (eg: trivial changes) type: enhancement Improvements to functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Appdirs vendor should not use win32api
2 participants